[
https://issues.apache.org/jira/browse/HADOOP-13597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765808#comment-15765808
]
Xiao Chen commented on HADOOP-13597:
------------------------------------
Thanks for the new rev [~jzhuge]. Feels pretty close to me. Seems all comments
are addressed to me too.
I only have the following book-keeping comments, other than that LGTM.
- ConfigurationWithLogging.java: javadoc should say about redaction.
- kms doc: we should still mention 9600 is the default port in {{KMS
Configuration}}.
- kms doc: the envvars (e.g. KMS_MAX_THREADS) needs documentation.
- kms doc: {{/jmx, /logLevel, /conf, /stack, /logs, and /static/index.html}}
needs documentation.
- The linked 'breaks' HADOOP-13872 KMS JMX exception seem to be fixed by this.
Could you confirm, and if so, close that one out? Don't see any option close to
'fixed by', but I think 'relates to' with a comment should be clear enough.
It's a fairly big patch, appreciate if other reviewers can take a look.
> Switch KMS from Tomcat to Jetty
> -------------------------------
>
> Key: HADOOP-13597
> URL: https://issues.apache.org/jira/browse/HADOOP-13597
> Project: Hadoop Common
> Issue Type: New Feature
> Components: kms
> Affects Versions: 2.6.0
> Reporter: John Zhuge
> Assignee: John Zhuge
> Attachments: HADOOP-13597.001.patch, HADOOP-13597.002.patch,
> HADOOP-13597.003.patch, HADOOP-13597.004.patch, HADOOP-13597.005.patch
>
>
> The Tomcat 6 we are using will reach EOL at the end of 2017. While there are
> other good options, I would propose switching to {{Jetty 9}} for the
> following reasons:
> * Easier migration. Both Tomcat and Jetty are based on {{Servlet
> Containers}}, so we don't have change client code that much. It would require
> more work to switch to {{JAX-RS}}.
> * Well established.
> * Good performance and scalability.
> Other alternatives:
> * Jersey + Grizzly
> * Tomcat 8
> Your opinions will be greatly appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
