[ 
https://issues.apache.org/jira/browse/HADOOP-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672764#comment-15672764
 ] 

Mingliang Liu edited comment on HADOOP-13822 at 11/17/16 5:20 AM:
------------------------------------------------------------------

That one is a bit tricky.

The parent JIRA itself is a patch and has committed. Then we had a few 
follow-on tasks. At that time I thought it may be resolved in weeks. After I 
realized the tasks have been pending review for a while, I regret not having 
created a logical umbrella JIRA.

Let's do this: we don't re-open the parent JIRA as the patch has been committed 
and backported to {{branch-2}} branch. Re-opening that will be confusing. 
Instead, let's get that code in. I need reviews and ping-ed Jitendra and Colin 
more than once; it seems they are busy in other projects and not actively 
reviewing the left 2 or 3 patches. Can I ask you here review/commit that 
patches?

# [HADOOP-13435] Add a new thread-local mechanism for aggregating file system 
storage stats. This includes the new ThreadLocalStorageStatistics class and its 
test and changes in FileSystemStorageStatistics that use it. After that, the 
FileSystemStorageStatistics can live without the deprecated 
FileSystem$Statistics implementation.
# [HADOOP-13032] Make FileSystems, FileContext, MapReduce and rack-aware read 
stats use the new FileSystemStorageStatistics interface. And remove the 
FileSystem$Statistics and update all its usages

Social coding is interesting. Thank you,


was (Author: liuml07):
That one is a bit tricky.

The parent JIRA itself is a patch and has committed. Then we had there are a 
few of follow-on tasks. At that time I thought that may be resolved in weeks. 
After I realized the tasks has been pending review for a while, I regret not 
having created a logical umbrella JIRA.

Let's do this: we don't re-open the parent JIRA as the patch has been 
committed, and backported to {{branch-2}} branch. Re-opening that will be 
confusing. Instead, let's get that code in. I need reviews and ping-ed Jitendra 
and Colin more than once; it seems they are busy in other projects and not 
actively reviewing the left 2 or 3 patches. Can I ask you here review/commit 
that patches?

# [HADOOP-13435] Add a new thread-local mechanism for aggregating file system 
storage stats. This includes the new ThreadLocalStorageStatistics class and its 
test and changes in FileSystemStorageStatistics that use it. After that, the 
FileSystemStorageStatistics can live without the deprecated 
FileSystem$Statistics implementation.
# [HADOOP-13032] Make FileSystems, FileContext, MapReduce and rack-aware read 
stats use the new FileSystemStorageStatistics interface. And remove the 
FileSystem$Statistics and update all its usages

> Use GlobalStorageStatistics.INSTANCE.reset() at FileSystem#clearStatistics()
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-13822
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13822
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: HADOOP-13822.patch
>
>
> As per my [comment 
> here|thttps://issues.apache.org/jira/browse/HADOOP-13283?focusedCommentId=15672426&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15672426]
>   GlobalStorageStatistics.INSTANCE.reset() can be used at 
> FileSystem#clearStatistics()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to