[ 
https://issues.apache.org/jira/browse/HADOOP-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596826#comment-15596826
 ] 

Xiao Chen commented on HADOOP-8500:
-----------------------------------

Thanks [~andrew.wang] for the patch. 

I tried to build before and after patch on trunk, with {{mvn clean site 
-Preleasedocs; mvn site:stage -DstagingDirectory=/tmp/hadoop-site}} and {{mvn 
clean package -Dtar -Pdist -DskipTests}}.

The 1st command didn't show any difference in the output, and I also verified 
the links work correctly (spot checked some pages including hadoop FileSystem's 
javadoc).

The 2nd command also successfully completes. Excitingly, the previously 72M 
{{hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar}} becomes 5.8M.


However, listing the hadoop-dist/target shows this:
{noformat}
before:
drwxr-xr-x   2 xiao  staff    68B Oct 21 17:33 test-dir
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:33 test-classes
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:33 maven-shared-archive-resources
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:33 classes
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:33 antrun
drwxr-xr-x  11 xiao  staff   374B Oct 21 17:33 hadoop-3.0.0-alpha2-SNAPSHOT
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:33 maven-archiver
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:33 javadoc-bundle-options
-rw-r--r--   1 xiao  staff    29K Oct 21 17:33 
hadoop-dist-3.0.0-alpha2-SNAPSHOT.jar
-rw-r--r--   1 xiao  staff    27K Oct 21 17:33 
hadoop-dist-3.0.0-alpha2-SNAPSHOT-test-sources.jar
-rw-r--r--   1 xiao  staff    27K Oct 21 17:33 
hadoop-dist-3.0.0-alpha2-SNAPSHOT-sources.jar
-rw-r--r--   1 xiao  staff   180M Oct 21 17:33 
hadoop-dist-3.0.0-alpha2-SNAPSHOT-javadoc.jar
-rw-r--r--   1 xiao  staff   179M Oct 21 17:33 
hadoop-3.0.0-alpha2-SNAPSHOT.tar.gz

after:
drwxr-xr-x   2 xiao  staff    68B Oct 21 17:39 test-dir
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:39 test-classes
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:39 maven-shared-archive-resources
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:39 classes
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:39 antrun
drwxr-xr-x  11 xiao  staff   374B Oct 21 17:39 hadoop-3.0.0-alpha2-SNAPSHOT
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:39 maven-archiver
drwxr-xr-x   3 xiao  staff   102B Oct 21 17:39 javadoc-bundle-options
-rw-r--r--   1 xiao  staff    29K Oct 21 17:39 
hadoop-dist-3.0.0-alpha2-SNAPSHOT.jar
-rw-r--r--   1 xiao  staff    27K Oct 21 17:39 
hadoop-dist-3.0.0-alpha2-SNAPSHOT-test-sources.jar
-rw-r--r--   1 xiao  staff    27K Oct 21 17:39 
hadoop-dist-3.0.0-alpha2-SNAPSHOT-sources.jar
-rw-r--r--   1 xiao  staff   179M Oct 21 17:39 
hadoop-3.0.0-alpha2-SNAPSHOT.tar.gz
{noformat}
That is, the final javadoc.jar is gone....?&%^!?

> Javadoc jars contain entire target directory
> --------------------------------------------
>
>                 Key: HADOOP-8500
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8500
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0-alpha
>         Environment: N/A
>            Reporter: EJ Ciramella
>            Assignee: Andrew Wang
>            Priority: Minor
>         Attachments: HADOOP-8500.001.patch, HADOOP-8500.patch, site-redo.tar
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The javadoc jars contain the contents of the target directory - which 
> includes classes and all sorts of binary files that it shouldn't.
> Sometimes the resulting javadoc jar is 10X bigger than it should be.
> The fix is to reconfigure maven to use "api" as it's destDir for javadoc 
> generation.
> I have a patch/diff incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to