[ 
https://issues.apache.org/jira/browse/HADOOP-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590914#comment-15590914
 ] 

Arpit Agarwal commented on HADOOP-13236:
----------------------------------------

Nice catch. +1 for the patch except a test case nitpick. The recoveryTriggered 
parameter to waitForRecovery is not necessary. Also waitForRecovery can have 
return type void as caller never uses the return value. You can probably 
replace this function with GenericTestUtils#waitFor.



> truncate will fail when we use viewfilesystem
> ---------------------------------------------
>
>                 Key: HADOOP-13236
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13236
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-13236-002.patch, HADOOP-13236.patch
>
>
> truncate will fail when use viewFS.
> {code}
>   @Override
>   public boolean truncate(final Path f, final long newLength)
>       throws IOException {
>     InodeTree.ResolveResult<FileSystem> res =
>         fsState.resolve(getUriPath(f), true);
>     return res.targetFileSystem.truncate(f, newLength);
>   }
>   {code}
>  *Path should be like below:* 
> {{return res.targetFileSystem.truncate(f, newLength);}}  *should be*  
> {{return res.targetFileSystem.truncate(res.remainingPath, newLength);}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to