[
https://issues.apache.org/jira/browse/HADOOP-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589483#comment-15589483
]
Daniel Templeton commented on HADOOP-10075:
-------------------------------------------
Latest patch looks great. One more round of quibbles:
* Seems like maybe {{1024 * 64}} should be a constant since it appears several
times. It's also still in there as {{1024*64}} a few times.
* In {{TestHttpServer}}, it would be better to use the constants instead of
{{"text/plain;charset=utf-8"}}. (That, by the way, is what I meant with you
stripping the space after the semicolon. You stripped it here, but then added
the space everywhere else.)
* In {{MiniKMS}}, you have {code}
((ServerConnector)server.getConnectors()[0]).getHost() + ":" +
((ServerConnector)server.getConnectors()[0]).getLocalPort());{code}
I believe the convention is to have the {{+}} at the start of the next line.
Same thing in {{JobEndNotifier}}.
* In {{ResourceGzMojo}} you should probably catch {{Exception}} instead of
{{Throwable}}: {code} } catch (Throwable t) {
throw new MojoExecutionException(t.toString(), t);
}{code} and {code} } catch (Throwable t) {
this.throwable = t;
}
} catch (Throwable t) {
this.throwable = t;
}{code}
> Update jetty dependency to version 9
> ------------------------------------
>
> Key: HADOOP-10075
> URL: https://issues.apache.org/jira/browse/HADOOP-10075
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.2.0, 2.6.0
> Reporter: Robert Rati
> Assignee: Robert Kanter
> Priority: Critical
> Attachments: HADOOP-10075-002-wip.patch, HADOOP-10075.003.patch,
> HADOOP-10075.004.patch, HADOOP-10075.005.patch, HADOOP-10075.006.patch,
> HADOOP-10075.007.patch, HADOOP-10075.008.patch, HADOOP-10075.009.patch,
> HADOOP-10075.patch
>
>
> Jetty6 is no longer maintained. Update the dependency to jetty9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
