[
https://issues.apache.org/jira/browse/HADOOP-13721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HADOOP-13721:
---------------------------------
Resolution: Fixed
Hadoop Flags: Incompatible change
Fix Version/s: 3.0.0-alpha2
Release Note: The unused method getTrashCanLocation has been removed. This
method has long been superceded by FileSystem#getTrashRoot.
Status: Resolved (was: Patch Available)
Committed to trunk.
Manoj, do you want to do another JIRA to mark this method as @Deprecated in
branch-2?
> Remove stale method ViewFileSystem#getTrashCanLocation
> ------------------------------------------------------
>
> Key: HADOOP-13721
> URL: https://issues.apache.org/jira/browse/HADOOP-13721
> Project: Hadoop Common
> Issue Type: Bug
> Components: viewfs
> Affects Versions: 3.0.0-alpha2
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Priority: Minor
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13721.01.patch
>
>
> {{ViewFileSystem}} which extends {{FileSystem}} has a public method
> {{getTrashCanLocation}} which is neither overridden nor used by anybody.
> Looks like it existed when the file was created, and also I see the
> implementation returning homeDirectory which might not be the expected one in
> cases of {{expunge}}. So, inclined to remove this stale and potentially
> dangerous method unless anyone has any concerns.
> {code}
> public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
> final InodeTree.ResolveResult<FileSystem> res =
> fsState.resolve(getUriPath(f), true);
> return res.isInternalDir() ? null :
> res.targetFileSystem.getHomeDirectory();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
