[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569128#comment-15569128
]
Eric Badger edited comment on HADOOP-13709 at 10/12/16 5:31 PM:
----------------------------------------------------------------
The TestShell#testShellCommandTimerLeak failure in the precommit seems to be
related to this patch. Locally it failed due to timeout 8/500 times with the
patch, but 0/500 times without the patch. The failure is happening when the
code gets blocked calling {{inReader.close()}}. Right above this code there is
a comment about how there was a JDK 7 issue that caused a race with trying to
close the stream, but that was supposedly fixed by the addition of
{{synchronized (stdout)}}.
was (Author: ebadger):
The TestShell#testShellCommandTimerLeak failure in the precommit seems to be
related to this patch. It fails with the patch due to timeout ~1/30 times, but
0/100 without the patch. The failure is happening when the code gets blocked
calling {{inReader.close()}}. Right above this code there is a comment about
how there was a JDK 7 issue that caused a race with trying to close the stream,
but that was supposedly fixed by the addition of {{synchronized (stdout)}}.
> Clean up subprocesses spawned by Shell.java:runCommand when the shell process
> exits
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-13709
> URL: https://issues.apache.org/jira/browse/HADOOP-13709
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Eric Badger
> Assignee: Eric Badger
> Attachments: HADOOP-13709.001.patch
>
>
> The runCommand code in Shell.java can get into a situation where it will
> ignore InterruptedExceptions and refuse to shutdown due to being in I/O
> waiting for the return value of the subprocess that was spawned. We need to
> allow for the subprocess to be interrupted and killed when the shell process
> gets killed. Currently the JVM will shutdown and all of the subprocesses will
> be orphaned and not killed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
