[
https://issues.apache.org/jira/browse/HADOOP-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-13703:
------------------------------------
Attachment: HADOOP-13560-branch-2-011.patch
Patch 011; address checkstyle warnings as well as can be done.
* mark some package scoped/inner classes as final
* chop down lines where appropriate
* rename some variables, and even when private final, wrap access from
subclasses in accessors. (needless, IMO)
Not done, hence checkstyle will still be complaining about. I don't intend to
address these.
* chop javadoc lines with link/crossref entries > 80 chars. checkstyle is
mistaken there.
* An "unused" import which is actually used in the javadocs
* use of tests named {{test_040_PositionedReadHugeFile()}}, public void
{{test_050_readHugeFile()}} in {{AbstractSTestS3AHugeFiles}}. This class has a
test runner which runs the tests in alphabetical order; they must run in
sequence. The naming scheme is designed to achieve this, and to highlight that
the numbering scheme here is special.
* use of {{ _1MB}} and {{_1KB}} constants in the test file. They're sizes, I
like them like that, and it is only a test file.
> S3ABlockOutputStream to pass Yetus & Jenkins
> --------------------------------------------
>
> Key: HADOOP-13703
> URL: https://issues.apache.org/jira/browse/HADOOP-13703
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.7.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13560-branch-2-010.patch,
> HADOOP-13560-branch-2-011.patch
>
>
> The HADOOP-13560 patches and PR has got yetus confused. This patch is purely
> to do test runs.
> h1. All discourse must continue to take place in HADOOP-13560 and/or the Pull
> Request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
