[ 
https://issues.apache.org/jira/browse/HADOOP-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561426#comment-15561426
 ] 

Hudson commented on HADOOP-13641:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10576 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10576/])
HADOOP-13641. Update UGI#spawnAutoRenewalThreadForUserCreds to reduce 
(kai.zheng: rev 3d59b18d49d98a293ae14c5b89d515ef83cc4ff7)
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java


> Update UGI#spawnAutoRenewalThreadForUserCreds to reduce indentation
> -------------------------------------------------------------------
>
>                 Key: HADOOP-13641
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13641
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Xiao Chen
>            Assignee: Huafeng Wang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: HADOOP-13641-branch-2.01.patch, HADOOP-13641.1.patch, 
> HADOOP-13641.2.patch
>
>
> From [~drankye]'s comment in HADOOP-13590:
> Could we return earlier at the beginning so we can avoid at least 2 level of 
> indents and make the whole block more readable?
> {code}
>   /**Spawn a thread to do periodic renewals of kerberos credentials*/
>   private void spawnAutoRenewalThreadForUserCreds() {
>     if (isSecurityEnabled()) {
>       //spawn thread only if we have kerb credentials
>       if (user.getAuthenticationMethod() == AuthenticationMethod.KERBEROS &&
>           !isKeytab) {
> ...
> ...
>                              very deep nested ...
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to