[ 
https://issues.apache.org/jira/browse/HADOOP-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557534#comment-15557534
 ] 

Kai Zheng commented on HADOOP-13701:
------------------------------------

Comments:
1. Better to check {{key.equals("/")}} as well.
{code}
+      // indicating "/" root directory.
+      if (key.equals("")) {
{code}

2. HADOOP-12977 added a good test when did the work for the case. How about 
also borrowing the test codes?

> AbstractContractRootDirectoryTest can fail after rebased with trunk
> -------------------------------------------------------------------
>
>                 Key: HADOOP-13701
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13701
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: HADOOP-12756
>            Reporter: Genmao Yu
>            Assignee: Genmao Yu
>             Fix For: HADOOP-12756
>
>         Attachments: HADOOP-13701-HADOOP-12756.001.patch, 
> HADOOP-13701-HADOOP-12756.002.patch
>
>
> AbstractContractRootDirectoryTest in hadoop-aliyun failed with patch in 
> HADOOP-12977. aliyun-oss needs also to support {{rm -rf "/"}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to