[ 
https://issues.apache.org/jira/browse/HADOOP-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556436#comment-15556436
 ] 

Xiao Chen commented on HADOOP-13669:
------------------------------------

Thanks [~sacharya] for revving. Looks good to me. We're just logging a debug 
log on any exception before throwing. This would make debugging problems a lot 
easier while not have much impact on normal usages.

Findbugs warnings are false alarm, since the exception is thrown.
+1 pending the below to nits (I'm the human checkstyle wizard):
- Line 198: s/{{} catch (Exception e){}}/{{} catch (Exception e) {}}/g
- Line 282: s/{{}catch (Exception e) {}}/{{} catch (Exception e) {}}/g

> KMS Server should log exceptions before throwing
> ------------------------------------------------
>
>                 Key: HADOOP-13669
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13669
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: Suraj Acharya
>              Labels: supportability
>         Attachments: HADOOP-13369.patch, HADOOP-13369.patch.1
>
>
> In some recent investigation, it turns out when KMS throws an exception (into 
> tomcat), it's not logged anywhere and we can only see the exception message 
> from client-side, but not the stacktrace. Logging the stacktrance would help 
> debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to