[
https://issues.apache.org/jira/browse/HADOOP-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530884#comment-15530884
]
Chris Nauroth commented on HADOOP-13560:
----------------------------------------
The documentation changes are looking good too. The content is fine, and I
just have minor comments.
The new troubleshooting sections are not nested correctly under the
"Troubleshooting S3A" top-level topic.
{code}
blocks of data (in S3 terms, "parts of a multipart upload). This can make more
{code}
Unmatched double-quotes.
{code}
to local hard disks in prior to upload. This minimizes the amount of memory
{code}
Remove "in".
{code}
This makes them a foundational part of the benchmarking
{code}
Missing period.
{code}
mvn verify -Pparallel-tests,scale -DtestsThreadCount=8
{code}
As per discussion on HADOOP-13614, we effectively can't use {{-P}} because of
Maven limitations. I suggest adding property-based activation to the new
profile, so we can activate scale tests by passing {{-Dscale}}.
{code}
<property>
<name>fs.s3a.scale.test.huge.filesize</name>
<value>20</value>
</property>
{code}
I suggest that we use {{Configuration#getLongBytes}} for this to support
configuring this with more human-readable values that include the unit
explicitly. I probably ought to go back and do the same for
scale.test.distcp.file.size.kb.
> S3ABlockOutputStream to support huge (many GB) file writes
> ----------------------------------------------------------
>
> Key: HADOOP-13560
> URL: https://issues.apache.org/jira/browse/HADOOP-13560
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-13560-branch-2-001.patch,
> HADOOP-13560-branch-2-002.patch, HADOOP-13560-branch-2-003.patch,
> HADOOP-13560-branch-2-004.patch
>
>
> An AWS SDK [issue|https://github.com/aws/aws-sdk-java/issues/367] highlights
> that metadata isn't copied on large copies.
> 1. Add a test to do that large copy/rname and verify that the copy really
> works
> 2. Verify that metadata makes it over.
> Verifying large file rename is important on its own, as it is needed for very
> large commit operations for committers using rename
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
