[
https://issues.apache.org/jira/browse/HADOOP-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490265#comment-15490265
]
Genmao Yu edited comment on HADOOP-13609 at 9/14/16 12:27 PM:
--------------------------------------------------------------
[~drankye]
1: "TemporaryAliyunCredentialsProvider" keep the same naming style with S3A.
2: Also keep the same implementation with S3A, providing a support for session
credentials
3: +1
updates:
1. AliyunOSSUtils#getPassword => AliyunOSSUtils#getAliyunAccessKeys
2. some renaming:
"accessKey" => "accessKeyId"
"secretKey" => "accessKeySecret"
"ACCESS_KEY" => "ACCESS_KEY_ID"
"SECRET_KEY" => "ACCESS_KEY_SECRET"
was (Author: unclegen):
[~drankye]
1: "TemporaryAliyunCredentialsProvider" keep the same naming style with S3A.
2: Also keep the same implementation with S3A, providing a support for session
credentials
3: +1
> Refine credential provider related codes for AliyunOss integration
> ------------------------------------------------------------------
>
> Key: HADOOP-13609
> URL: https://issues.apache.org/jira/browse/HADOOP-13609
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: HADOOP-12756
> Reporter: Kai Zheng
> Assignee: Genmao Yu
> Fix For: HADOOP-12756
>
>
> looking at the AliyunOss integration codes, some findings:
> 1. {{TemporaryAliyunCredentialsProvider}} could be better named;
> 2. TemporaryAliyunCredentialsProvider shared many codes with
> {{AliyunOSSUtils#getCredentialsProvider}}, and the dup can be resolved;
> 3. {{AliyunOSSUtils#getPassword}} is rather confusing, as used to get other
> things than password.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
