[
https://issues.apache.org/jira/browse/HADOOP-13605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490051#comment-15490051
]
Steve Loughran commented on HADOOP-13605:
-----------------------------------------
Test failed as the error message on a load failure now quotes the scheme, and
the test was looking for the exact string.
{code}
org.junit.ComparisonFailure: expected:<...ileSystem for scheme[: null]> but
was:<...ileSystem for scheme[ "null"]>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.hadoop.fs.TestFileSystemCaching.testDefaultFsUris(TestFileSystemCaching.java:99)
{code}
as the FS code now throws a specific subclass of IOE,
{{UnsupportedFileSystemException}}, the message check can be replaced with a
catch of that explicit exception type instead.
> Clean up FileSystem javadocs, logging; improve diagnostics on FS load
> ---------------------------------------------------------------------
>
> Key: HADOOP-13605
> URL: https://issues.apache.org/jira/browse/HADOOP-13605
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13605-branch-2-001.patch
>
>
> We can't easily debug FS instantiation problems as there isn't much detail in
> what was going on.
> We can add more logging, but cannot simply switch {{FileSystem.LOG}} to SLF4J
> —the class is used in too many places, including tests which cast it.
> Instead, add a new private SLF4J Logger, {{LOGGER}} and switch logging to it.
> While working in the base FileSystem class, take the opportunity to clean up
> javadocs and comments
> # add the list of exceptions, including indicating which base classes throw
> UnsupportedOperationExceptions
> # cut bits in the comments which are not true
> The outcome of this patch is that IDEs shouldn't highlight most of the file
> as flawed in some way or another
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
