[
https://issues.apache.org/jira/browse/HADOOP-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471847#comment-15471847
]
Jason Lowe commented on HADOOP-13218:
-------------------------------------
The Jenkins build here didn't hit the failures because the precommit builds
only run the tests in the maven projects that were touched by the patch. This
patch touched MapReduce but only in the history server project. If it had
touched the jobclient project then you would have seen the failures. In short,
you cannot know for certain that a patch doesn't break something when the
precommit build is clean because the precommit build doesn't run *all* of the
tests due to how long that would take for each precommit build.
See
https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/157/#showFailuresLink
for a nightly build sample. Any precommit build that needs to run tests in
jobclient is going to report a lot of failures due to this still being in the
build.
bq. The changing of the default RPC engine is unexpected and deeply sorry for
that.
The summary implies this is just about tests, but it is not. It changes the
default RPC engine. If that change is unexpected then this patch should be
reverted, that portion removed from the patch, and then reviewed and
recommitted.
> Migrate other Hadoop side tests to prepare for removing WritableRPCEngine
> -------------------------------------------------------------------------
>
> Key: HADOOP-13218
> URL: https://issues.apache.org/jira/browse/HADOOP-13218
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test
> Reporter: Kai Zheng
> Assignee: Wei Zhou
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13218-v01.patch, HADOOP-13218-v02.patch
>
>
> Patch for HADOOP-12579 contains lots of work to migrate the left Hadoop side
> tests basing on the new RPC engine and nice cleanups. HADOOP-12579 will be
> reverted to allow some time for YARN/Mapreduce side related changes, open
> this to recommit most of the test related work in HADOOP-12579 for easier
> tracking and maintain, as other sub-tasks did.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
