[
https://issues.apache.org/jira/browse/HADOOP-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412611#comment-15412611
]
Hudson commented on HADOOP-13380:
---------------------------------
SUCCESS: Integrated in Hadoop-trunk-Commit #10238 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10238/])
HADOOP-13380. TestBasicDiskValidator should not write data to /tmp (lei: rev
6418edd6feeafc0204536e1860942eeb1cb1a9ce)
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDiskChecker.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestBasicDiskValidator.java
> TestBasicDiskValidator should not write data to /tmp
> ----------------------------------------------------
>
> Key: HADOOP-13380
> URL: https://issues.apache.org/jira/browse/HADOOP-13380
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Lei (Eddy) Xu
> Assignee: Yufei Gu
> Priority: Minor
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13380.001.patch, HADOOP-13380.002.patch
>
>
> In {{TestBasicDiskValidator}}, the following code is confusing
> {code}
> File localDir = File.createTempFile("test", "tmp");
> try {
> if (isDir) {
> // reuse the file path generated by File#createTempFile to create a dir
> localDir.delete();
> localDir.mkdir();
> }
> {code}
> Btw, as suggested in https://wiki.apache.org/hadoop/CodeReviewChecklist, unit
> test should not write data into {{/tmp}}:
> bq. * unit tests do not write any temporary files to /tmp (instead, the tests
> should write to the location specified by the test.build.data system property)
> Finally, should use {{Files}} in these file creation / deletion, so that any
> error can be thrown as {{IOE}}.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
