[
https://issues.apache.org/jira/browse/HADOOP-13428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398184#comment-15398184
]
Wangda Tan commented on HADOOP-13428:
-------------------------------------
[~andrew.wang],
The error is caused by a known jdiff bug:
https://sourceforge.net/p/javadiff/bugs/19/
In MetricSystem, there're two register overloads have same parameter types and
return types, but one is <T extends MetricsSink> and another one is <T>.
However, jdiff cannot recognize it. So I just attached a workaround patch
https://issues.apache.org/jira/secure/attachment/12820786/metric-system-temp-fix.patch,
to temporarily remove one of the register method. I think we should not commit
it to our code base, but we can temporally apply it when generating jdiff.
The steps of generate jdiff is:
1) Apply
https://issues.apache.org/jira/secure/attachment/12820787/HADOOP-13428.2.patch,
which include jdiff file of hadoop-common from 2.7.3 and update pom to compare
to 2.7.3.
2) Apply metric-system temp fix
3) Run {{mvn clean package -Pdocs -DskipTests}}
4) Result:
- Generated jdiff file:
{{hadoop-common-project/hadoop-common/target/site/jdiff/xml/Apache_Hadoop_Common_3.0.0-alpha2-SNAPSHOT.xml}}
- Generated jdiff report:
{{hadoop-common-project/hadoop-common/target/site/jdiff/xml/changes.html}}
> Fix hadoop-common to generate jdiff
> -----------------------------------
>
> Key: HADOOP-13428
> URL: https://issues.apache.org/jira/browse/HADOOP-13428
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Blocker
> Attachments: HADOOP-13428.1.patch, HADOOP-13428.2.patch,
> metric-system-temp-fix.patch
>
>
> Hadoop-common failed to generate JDiff. We need to fix that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
