[ 
https://issues.apache.org/jira/browse/HADOOP-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389642#comment-15389642
 ] 

Steve Loughran commented on HADOOP-13406:
-----------------------------------------

I like the performance boost: 1-2 extra getFileStatus calls saved, leading to 
4+ HTTP requests saved on a file copy operation.

Patch-wise -1 as is. Adds a bit of convolution to the code, with a new 
innerDelete. I've done a rework which I'll see what Jenkins thinks of. This 
reduces the diff between the branch and your patch more (no new innerDelete), 
changes the javadocs.

> S3AFileSystem: Consider reusing filestatus in delete() and mkdirs()
> -------------------------------------------------------------------
>
>                 Key: HADOOP-13406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 2.8.0
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HADOOP-13406-branch-2-001.patch
>
>
> filestatus can be reused in rename() and in mkdirs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to