[ 
https://issues.apache.org/jira/browse/HADOOP-13240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371671#comment-15371671
 ] 

John Zhuge commented on HADOOP-13240:
-------------------------------------

For comparison, I ran the {{setfacl -m "" /path}} on Ubuntu 14.04:
{noformat}
$ cat /etc/issue
Ubuntu 14.04.4 LTS \n \l

$ ls -ld /path
-rw-rw-r--+ 1 root root 0 Jul 11 21:06 /path
$ sudo setfacl -m "" /path
Usage: setfacl [-bkndRLP] { -m|-M|-x|-X ... } file ...
Try `setfacl --help' for more information.
$ sudo setfacl -m "user:ubuntu:rw-" /path
{noformat}

> TestAclCommands.testSetfaclValidations fail
> -------------------------------------------
>
>                 Key: HADOOP-13240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13240
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.1, 2.7.1
>         Environment: hadoop 2.4.1,as6.5
>            Reporter: linbao111
>            Assignee: John Zhuge
>            Priority: Minor
>
> mvn test -Djava.net.preferIPv4Stack=true -Dlog4j.rootLogger=DEBUG,console 
> -Dtest=TestAclCommands#testSetfaclValidations failed with following message:
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.fs.shell.TestAclCommands
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.599 sec <<< 
> FAILURE! - in org.apache.hadoop.fs.shell.TestAclCommands
> testSetfaclValidations(org.apache.hadoop.fs.shell.TestAclCommands)  Time 
> elapsed: 0.534 sec  <<< FAILURE!
> java.lang.AssertionError: setfacl should fail ACL spec missing
>         at org.junit.Assert.fail(Assert.java:93)
>         at org.junit.Assert.assertTrue(Assert.java:43)
>         at org.junit.Assert.assertFalse(Assert.java:68)
>         at 
> org.apache.hadoop.fs.shell.TestAclCommands.testSetfaclValidations(TestAclCommands.java:81)
> i notice from 
> HADOOP-10277,hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/AclEntry.java
>  code changed
> should 
> hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.javabe
>  changed to:
> diff --git 
> a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
>  
> b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
> index b14cd37..463bfcd
> --- 
> a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
> +++ 
> b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
> @@ -80,7 +80,7 @@ public void testSetfaclValidations() throws Exception {
>              "/path" }));
>      assertFalse("setfacl should fail ACL spec missing",
>          0 == runCommand(new String[] { "-setfacl", "-m",
> -            "", "/path" }));
> +            ":", "/path" }));
>    }
>  
>    @Test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to