[
https://issues.apache.org/jira/browse/HADOOP-13280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337000#comment-15337000
]
Mingliang Liu commented on HADOOP-13280:
----------------------------------------
Thansk [~cmccabe] for the review and comments.
{code}
Long.valueOf(data.getLargeReadOps());
{code}
{{data.getReadOps()}} is int type and {{Long.valueOf(long)}} accepts a long
type parameter. Thus the implicit typecast can not be avoided I think?
Besides my IntelliJ 2016.1 along with Java 8 suggests the boxing is
unnecessary. But I think it's actually a matter of coding style.
> FileSystemStorageStatistics#getLong(“readOps“) should return readOps +
> largeReadOps
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-13280
> URL: https://issues.apache.org/jira/browse/HADOOP-13280
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-13280-branch-2.8.000.patch,
> HADOOP-13280.000.patch, HADOOP-13280.001.patch
>
>
> Currently {{FileSystemStorageStatistics}} instance simply returns data from
> {{FileSystem$Statistics}}. As to {{readOps}}, the
> {{FileSystem$Statistics#getReadOps()}} returns {{readOps + largeReadOps}}. We
> should make the {{FileSystemStorageStatistics#getLong(“readOps“)}} return the
> sum as well.
> Moreover, there is no unit tests for {{FileSystemStorageStatistics}} and this
> JIRA will also address this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
