[
https://issues.apache.org/jira/browse/HADOOP-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307653#comment-15307653
]
Steve Loughran commented on HADOOP-13131:
-----------------------------------------
bq. I'm not sure why {{getObjectMetadata(String)}} is protected. Should that be
private?
done.
bq. Suggest capitalizing "Amazon S3".
done.
bq. No-op default {{TestS3AEncryption()}} constructor can be removed?
done
bq. Would it be better to do this config setup by overriding
AbstractFSContractTestBase#createConfiguration?
well spotted! Done.
bq. S3AFastOutputStream also supports server-side encryption. What would you
think of adding a test covering that?
done. I know the code has been unified, but it's trivial to add the second
option.
bq. change the thread name to {{"JUnit-" + methodName}}, so that the thread
name is specific to the test being run.
Done. I only want the name for distinguishing output in logs, having the method
name in there can only be even more informative.
> Add tests to verify that S3A supports SSE-S3 encryption
> -------------------------------------------------------
>
> Key: HADOOP-13131
> URL: https://issues.apache.org/jira/browse/HADOOP-13131
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.7.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-13131-001.patch, HADOOP-13131-002.patch,
> HADOOP-13131-003.patch, HADOOP-13131-004.patch, HADOOP-13131-005.patch,
> HADOOP-13131-branch-2-006.patch, HADOOP-13131-branch-2-007.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Although S3A claims to support server-side S3 encryption (and does, if you
> set the option), we don't have any test to verify this. Of course, as the
> encryption is transparent, it's hard to test.
> Here's what I propose
> # a test which sets encryption = AES256; expects things to work as normal.
> # a test which sets encyption = DES and expects any operation creating a file
> or directory to fail with a 400 "bad request" error
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
