[
https://issues.apache.org/jira/browse/HADOOP-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290455#comment-15290455
]
Xiaobing Zhou commented on HADOOP-13168:
----------------------------------------
Thank you working on this. Some comments:
1. AsyncGet
For doc of AsyncGet#get, would 'When timeout == 0' better be 'When timeout = 0'?
@return doc should be added for Util#asyncGetTimeout2WaitTimeout
In Util#asyncGetTimeout2WaitTimeout, it returns 1 ms, is it possible to lead to
overhead given huge number of calls? Can we use a smaller time unit?
Object#wait(long timeout, int nanos) could be used in that case.
2. ipc.Client
In ipc.Client#call, make #get override has the same signature as AsyncGet#get,
e.g.
AsyncGet#get(long timeout, TimeUnit unit) throws IOException,
TimeoutException, InterruptedException
If getRpcResponse throws IOException, there's no chance to change done back
3. ProtobufRpcEngine
Similarly, make #get override has the same signature as AsyncGet#get
> Support Future.get with timeout in ipc async calls
> --------------------------------------------------
>
> Key: HADOOP-13168
> URL: https://issues.apache.org/jira/browse/HADOOP-13168
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: c13168_20160517.patch, c13168_20160518.patch
>
>
> Currently, the Future returned by ipc async call only support Future.get()
> but not Future.get(timeout, unit). We should support the latter as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
