[ 
https://issues.apache.org/jira/browse/HADOOP-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286240#comment-15286240
 ] 

Steve Loughran commented on HADOOP-13162:
-----------------------------------------

When writing tests, imagine "what information would I need to debug this if it 
failed on jenkins". All asserts need meaningful messages.

Here'd I'd actually use {{ContractTestUtils.assertIsDirectory()}} which gives 
the message and the full filestatus on a failure

> Consider reducing number of getFileStatus calls in S3AFileSystem.mkdirs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-13162
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13162
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>            Reporter: Rajesh Balamohan
>         Attachments: HADOOP-13162.001.patch
>
>
> getFileStatus is relatively expensive call and mkdirs invokes it multiple 
> times depending on how deep the directory structure is. It would be good to 
> reduce the number of getFileStatus calls in such cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to