[ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275819#comment-15275819
 ] 

Matthew Paduano commented on HADOOP-13112:
------------------------------------------

thanks for the heads up.  

HADOOP-12942 patch will conflict with this one in the
run() method and the logic handling usage messaging... 
not sure how important that is.  supposing the base 
class was already in place, would HADOOP-12942 still 
try to modify those methods?

KeyShell does indeed look like a candidate to save some
code and consolidate the base class.  I will add it to this patch. 


> Change CredentialShell to use CommandShell base class
> -----------------------------------------------------
>
>                 Key: HADOOP-13112
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13112
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Matthew Paduano
>            Assignee: Matthew Paduano
>            Priority: Minor
>         Attachments: HADOOP-13112.01.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to