[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229725#comment-15229725
]
Elliott Clark commented on HADOOP-12973:
----------------------------------------
bq.There's no benefit to changing this class from non-static to static, if it
needs to keep a reference to the parent DU object anyway, right?
It makes it more obvious when someone overrides the class where things are.
bq.There is a non-obvious coupling between DU and WindowsDU, since one is a
subclass of the other.
It keeps people changing DU from having to support both windows and linux.
bq.Any MapReduce code that is using DU directly will now break on Windows,
unless it is modified to explicitly use WindowsDU when appropriate
This is limited private and there are no other places that I haven't changed.
bq.can we make this a builder instead?
I don't see the added complexity/
bq.Do we need both decDfsUsed and incDfsUsed? Can't we just add a negative? Or
is that too unintuitive?
Sure.
bq.Is GetSpaceUsed#start really necessary?
Shutdown is needed. So it's very strange to have a shutdown without a start.
> make DU pluggable
> -----------------
>
> Key: HADOOP-12973
> URL: https://issues.apache.org/jira/browse/HADOOP-12973
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HADOOP-12973v0.patch, HADOOP-12973v1.patch,
> HADOOP-12973v2.patch, HADOOP-12973v3.patch, HADOOP-12973v5.patch,
> HADOOP-12973v6.patch, HADOOP-12973v7.patch, HADOOP-12973v8.patch,
> HADOOP-12973v9.patch
>
>
> If people are concerned about replacing the call to DU. Then an easy first
> step is to make it pluggable. Then it's possible to replace it with something
> while leaving the default alone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
