[ 
https://issues.apache.org/jira/browse/HADOOP-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei-Chiu Chuang updated HADOOP-12895:
-------------------------------------
    Description: 
If in SERVER model, the following code should throw exception indicating 
Factory is in SERVER mode, not in CLIENT mode. Otherwise, it could be confusing.
{code:title=SSLSocketFactory.java}
public SSLSocketFactory createSSLSocketFactory()
    throws GeneralSecurityException, IOException {
    if (mode != Mode.CLIENT) {
      throw new IllegalStateException("Factory is in CLIENT mode");
    }
    return context.getSocketFactory();
  }
{code}

  was:
If in SERVER model, the following code should throw exception indicating 
Factory is in SERVER mode, not in CLIENT mode.
{code:title=SSLSocketFactory.java}
public SSLSocketFactory createSSLSocketFactory()
    throws GeneralSecurityException, IOException {
    if (mode != Mode.CLIENT) {
      throw new IllegalStateException("Factory is in CLIENT mode");
    }
    return context.getSocketFactory();
  }
{code}


> SSLFactory#createSSLSocketFactory exception message is wrong
> ------------------------------------------------------------
>
>                 Key: HADOOP-12895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12895
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.2-alpha
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Trivial
>         Attachments: HADOOP-12895.001.patch
>
>
> If in SERVER model, the following code should throw exception indicating 
> Factory is in SERVER mode, not in CLIENT mode. Otherwise, it could be 
> confusing.
> {code:title=SSLSocketFactory.java}
> public SSLSocketFactory createSSLSocketFactory()
>     throws GeneralSecurityException, IOException {
>     if (mode != Mode.CLIENT) {
>       throw new IllegalStateException("Factory is in CLIENT mode");
>     }
>     return context.getSocketFactory();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to