[jira] [Commented] (HADOOP-12808) Follow-on of HADOOP-12041

[Zhe Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151412#comment-15151412
 ] 

Zhe Zhang commented on HADOOP-12808:
------------------------------------

Thanks Rui for the work.

Quick question: did you use {{git mv}} for the rename? That would make the 
patch much more cleaner:
{code}
zhezhang-MBP:trunk zhezhang$ git mv 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoder.java
 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoderLegacy.java
zhezhang-MBP:trunk zhezhang$ git mv 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoder2.java
 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoder.java
zhezhang-MBP:trunk zhezhang$ git st
On branch trunk
Your branch is up-to-date with 'apache/trunk'.
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

        renamed:    
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoder2.java
 -> 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoder.java
        renamed:    
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoder.java
 -> 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RSRawDecoderLegacy.java
{code}

Right now it shows a lot of in-place modifications in {{RSRawDecoder.java}}

> Follow-on of HADOOP-12041
> -------------------------
>
>                 Key: HADOOP-12808
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12808
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Rui Li
>            Assignee: Rui Li
>         Attachments: HADOOP-12808.1.patch, HADOOP-12808.2.patch, 
> HADOOP-12808.3.patch
>
>
> We can use this JIRA to rename the new Java coder and make it default for 
> HDFS-EC. Package-info is also needed after HADOOP-12041.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)