[
https://issues.apache.org/jira/browse/HADOOP-12794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148334#comment-15148334
]
Junping Du commented on HADOOP-12794:
-------------------------------------
Thanks [~rmutyala] for updating the patch. The patch looks petty good now. Just
one NIT:
bq. If anyone thinks adding a new one instead of modifying existing test is the
best option here, I can upload another version with a new test case.
As a general practice, we normally suggest to add an additional test case
rather than modifying existing test cases for new feature/configuration as
previous test case could be designed for some other purpose. In this particular
case, it would be nice to have an additional test method to verify all
compression levels.
Mark target version to be 2.7.3 and 2.8.0.
> Support additional compression levels for GzipCodec
> ---------------------------------------------------
>
> Key: HADOOP-12794
> URL: https://issues.apache.org/jira/browse/HADOOP-12794
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.7.2
> Reporter: Ravi Mutyala
> Assignee: Ravi Mutyala
> Attachments: HADOOP-12794.0001.patch, HADOOP-12794.0002.patch
>
>
> gzip supports compression levels 1-9. Compression level 4 seems to give best
> compression per CPU time in some of our tests. Right now ZlibCompressor that
> is used by GzipCodec only supports levels 1,9 and six (default).
> Adding all the compression levels that are supported by native ZlibCompressor
> can provide more options to tweak compression levels.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
