[
https://issues.apache.org/jira/browse/HADOOP-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136445#comment-15136445
]
Andrew Wang commented on HADOOP-12775:
--------------------------------------
This looks good overall, I applied HDFS-9637 to see the tests too. I'd like it
if we posted tests and code together, since when it's split we don't have
precommit coverage.
Q about the testing static variables. I haven't worked much with the metrics
system, but is there really no way to provide a configuration when
instantiating? Needing statics to set these members is pretty gross, and makes
the code bigger.
Also, have you considered making the roll interval configurable? That way we
wouldn't need a {{flushQuickly}} property. Seems useful since not all
deployments will necessarily want hourly rolling.
> RollingFileSystemSink doesn't work on secure clusters
> -----------------------------------------------------
>
> Key: HADOOP-12775
> URL: https://issues.apache.org/jira/browse/HADOOP-12775
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: HADOOP-12775.001.patch, HADOOP-12775.002.patch,
> HADOOP-12775.003.patch
>
>
> If HDFS has kerberos enabled, the sink cannot write its logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
