[
https://issues.apache.org/jira/browse/HADOOP-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056832#comment-15056832
]
Zhe Zhang commented on HADOOP-12615:
------------------------------------
Thanks Wei-Chiu for the fix! A few questions/comments
# We should avoid wildcard imports: {{import java.io.*;}}
# Could you add to the description the failed test you saw? I think we should
only throw exception for the NPE that showed up. For some other places, I
suspect some logics could handle a null inputstream already. For example, looks
like {{PropertyConfigurator.configure(in)}} does nothing if {{in}} is null.
> Fix NPE in MiniKMS.start()
> --------------------------
>
> Key: HADOOP-12615
> URL: https://issues.apache.org/jira/browse/HADOOP-12615
> Project: Hadoop Common
> Issue Type: Bug
> Components: kms, test
> Affects Versions: 3.0.0
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Minor
> Labels: jenkins, supportability, test
> Attachments: HADOOP-12615.001.patch, HADOOP-12615.002.patch
>
>
> Sometimes, KMS resource file can not be loaded. When this happens, an
> InputStream variable will be a null pointer which will subsequently throw NPE.
> This is a supportability JIRA that makes the error message more explicit, and
> explain why NPE is thrown. Ultimately, leads us to understand why the
> resource files can not be loaded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
