[
https://issues.apache.org/jira/browse/HADOOP-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744153#action_12744153
]
Konstantin Boudnik commented on HADOOP-6196:
--------------------------------------------
A few comments:
- new unit test is developed under JUnit3 conventions (e,g, it extends
TestCase, imports junit.framework, etc.) I'd suggest to make it JUnit4
compliant: remove TestCase extention, add {...@test}} annotation to the test
method, use {{org.junit.*}} packages instead
- it seems that the unit test doesn't cover all the cases described in a
comment above.
bq. Strangely, it works sometimes and breaks other times. When it works, it'll
tend to work for a few times in a row until a few seconds pass and then it
starts breaking again (EOFException at readInt)
It seems to be more sensible to do a number of {{seek(0); next()}} followed by
a random pauses and {{seek()}} calls to locations differ from 0
- {{SequenceFile.java}} has some white-space only modifications, e.g.
{noformat}
- if (!blockCompressed) {
+ if (!blockCompressed) {
{noformat}
> sync(0); next() breaks SequenceFile
> -----------------------------------
>
> Key: HADOOP-6196
> URL: https://issues.apache.org/jira/browse/HADOOP-6196
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Jay Booth
> Attachments: sync-bug.patch
>
>
> Currently, the end of the SequenceFile header is a sync block that isn't
> prefaced with SYNC_ESCAPE. This means that sync(0) followed by next() fails.
> Patch w/ test attached, bumps VERSION from 6 to 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
