This is an automated email from the ASF dual-hosted git repository.

tbonelee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new d63fda3797 [ZEPPELIN-6636] Use lint-staged's local binary resolution 
instead of explicit node_modules paths
d63fda3797 is described below

commit d63fda37973052b7a684cba8450e289a942b2dbc
Author: Naeun Park <[email protected]>
AuthorDate: Mon Oct 5 22:19:02 2026 +0900

    [ZEPPELIN-6636] Use lint-staged's local binary resolution instead of 
explicit node_modules paths
    
    ### What is this PR for?
    `lint-staged` in `zeppelin-web-angular/package.json` mixes two conventions: 
`cross-env` and `eslint` are invoked by bare name, while `prettier` uses an 
explicit `./node_modules/.bin/prettier` path.
    
    lint-staged runs tasks through execa with `preferLocal` enabled, so locally 
installed binaries resolve by bare name. The explicit path is unnecessary and 
fragile, since it depends on the working directory (e.g. if nested packages add 
their own lint-staged configuration).
    
    This PR drops the `./node_modules/.bin/` prefix from both `prettier 
--write` entries.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - Remove `./node_modules/.bin/` prefix from the lint-staged prettier 
tasks
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-6636
    
    ### How should this be tested?
    * Stage a `.ts` file with bad formatting and run `npx lint-staged` in 
`zeppelin-web-angular/`: `eslint --fix` runs first, then `prettier --write` 
reformats the file.
    * Stage a `.json`/`.js`/`.css`/`.html` file and run `npx lint-staged`: 
`prettier --write` runs on it.
    * Committing triggers the same flow through the Husky pre-commit hook.
    * No `./node_modules/.bin/` prefix remains in the `lint-staged` 
configuration.
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the license files need to update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Closes #5543 from world970511/ZEPPELIN-6636.
    
    Signed-off-by: ChanHo Lee <[email protected]>
---
 zeppelin-web-angular/package.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/zeppelin-web-angular/package.json 
b/zeppelin-web-angular/package.json
index fe9a70398b..08c1da8017 100644
--- a/zeppelin-web-angular/package.json
+++ b/zeppelin-web-angular/package.json
@@ -140,10 +140,10 @@
   "lint-staged": {
     "**/*.{ts,mts}": [
       "cross-env NODE_OPTIONS='--max-old-space-size=8192' eslint --fix",
-      "./node_modules/.bin/prettier --write"
+      "prettier --write"
     ],
     "**/*.{js,mjs,json,css,html}": [
-      "./node_modules/.bin/prettier --write"
+      "prettier --write"
     ]
   }
 }

Reply via email to