This is an automated email from the ASF dual-hosted git repository.

tbonelee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 156cd54896 [ZEPPELIN-6541] Pin maven-checkstyle-plugin version so it 
is actually applied
156cd54896 is described below

commit 156cd548968d90b62e7cf262b369abd96f0c042d
Author: Gyeongtae Park <[email protected]>
AuthorDate: Sun Jul 19 02:49:09 2026 +0900

    [ZEPPELIN-6541] Pin maven-checkstyle-plugin version so it is actually 
applied
    
    ### What is this PR for?
    The root `pom.xml` declares a `plugin.checkstyle.version` property (`2.17`) 
intended to pin the `maven-checkstyle-plugin` version used across all modules, 
but the plugin's `<pluginManagement>` declaration never referenced it via a 
`<version>` tag. As a result Maven silently resolved a different, 
non-deterministic plugin version regardless of what the property said — 
confirmed locally: the property said `2.17`, but the build actually ran 
`checkstyle:3.4.0:check`. This PR adds the missi [...]
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] Add `<version>${plugin.checkstyle.version}</version>` to the 
`maven-checkstyle-plugin` block in `<pluginManagement>`
    * [x] Bump `plugin.checkstyle.version` from `2.17` to `3.6.0`
    
    ### What is the Jira issue?
    
[ZEPPELIN-6541](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-6541)
    
    ### How should this be tested?
    ```bash
    ./mvnw -pl shell verify -DskipTests
    ```
    Confirm the log shows checkstyle:3.6.0:check (not an arbitrary/older 
version) and the build completes with BUILD SUCCESS. No module overrides the 
plugin version locally, so all modules using maven-checkstyle-plugin inherit 
the pinned version consistently.
    
    
    Screenshots (if appropriate)
    
    N/A
    
    Questions:
    
    - Does the license files need to update? No.
    - Is there breaking changes for older versions? No — build-time only 
change, no runtime behavior affected.
    - Does this needs documentation? No.
    
    Closes #5308 from ParkGyeongTae/ZEPPELIN-6541.
    
    Signed-off-by: ChanHo Lee <[email protected]>
---
 pom.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 62fe3a5b2d..8ddaa73ec7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -158,7 +158,6 @@
     <plugin.avro.version>1.7.7</plugin.avro.version>
     <plugin.buildhelper.version>1.7</plugin.buildhelper.version>
     <plugin.buildnumber.version>1.4</plugin.buildnumber.version>
-    <plugin.checkstyle.version>2.17</plugin.checkstyle.version>
     <plugin.cobertura.version>2.7</plugin.cobertura.version>
     <plugin.download.version>1.6.0</plugin.download.version>
     <plugin.exec.version>1.6.0</plugin.exec.version>

Reply via email to