This is an automated email from the ASF dual-hosted git repository.
chanholee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new 88521103ff [ZEPPELIN-6382] Add configuration to remove unused
variables, parameters, and imports for New UI
88521103ff is described below
commit 88521103ffcafee094705f3df6f30fde5c1ea21a
Author: YONGJAE LEE(이용재) <[email protected]>
AuthorDate: Tue Dec 2 17:47:38 2025 +0900
[ZEPPELIN-6382] Add configuration to remove unused variables, parameters,
and imports for New UI
### What is this PR for?
- Enforced unused-variable checks via ESLint
(<at>typescript-eslint/no-unused-vars).
- Activated strict TypeScript checks in E2E tests (noUnusedLocals,
noUnusedParameters).
- Apply eslint, tsc
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
ZEPPELIN-6382
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #5123 from dididy/fix/unused-part.
Signed-off-by: ChanHo Lee <[email protected]>
---
zeppelin-web-angular/.editorconfig | 2 +-
zeppelin-web-angular/.eslintrc.json | 8 +++++++-
.../tests/authentication/anonymous-login-redirect.spec.ts | 4 +---
.../tests/home/home-page-enhanced-functionality.spec.ts | 12 ++++++------
.../e2e/tests/home/home-page-layout.spec.ts | 3 ---
.../e2e/tests/home/home-page-note-operations.spec.ts | 15 ++++-----------
.../e2e/tests/home/home-page-notebook-actions.spec.ts | 14 +++++++-------
zeppelin-web-angular/e2e/tests/theme/dark-mode.spec.ts | 2 +-
.../notebook-repos/notebook-repo-item-display.spec.ts | 3 ---
.../notebook-repo-item-form-validation.spec.ts | 3 ---
.../notebook-repos/notebook-repo-item-settings.spec.ts | 3 ---
zeppelin-web-angular/e2e/tsconfig.json | 8 ++++++--
zeppelin-web-angular/e2e/utils.ts | 3 +--
.../src/g2-visualization-component-base.ts | 2 +-
.../src/app/core/paragraph-base/paragraph-base.ts | 5 ++---
zeppelin-web-angular/src/app/pages/login/login.guard.ts | 2 +-
.../src/app/pages/workspace/home/home.component.ts | 2 +-
.../pages/workspace/job-manager/job-manager.component.ts | 4 ++--
.../app/pages/workspace/job-manager/job/job.component.ts | 2 +-
.../workspace/notebook/action-bar/action-bar.component.ts | 10 +++++-----
.../interpreter-binding/interpreter-binding.component.ts | 2 +-
.../app/pages/workspace/notebook/notebook.component.ts | 4 ++--
.../workspace/published/paragraph/paragraph.component.ts | 2 +-
.../share/dynamic-forms/dynamic-forms.component.ts | 2 +-
.../app/pages/workspace/share/result/result.component.ts | 2 +-
zeppelin-web-angular/src/app/services/helium.service.ts | 2 +-
.../pie-chart/pie-chart-visualization.component.ts | 2 +-
.../scatter-chart-visualization.component.ts | 2 +-
28 files changed, 56 insertions(+), 69 deletions(-)
diff --git a/zeppelin-web-angular/.editorconfig
b/zeppelin-web-angular/.editorconfig
index c220b3125b..e32582f5be 100644
--- a/zeppelin-web-angular/.editorconfig
+++ b/zeppelin-web-angular/.editorconfig
@@ -5,7 +5,7 @@ root = true
charset=utf-8
end_of_line=lf
trim_trailing_whitespace=true
-insert_final_newline=false
+insert_final_newline=true
indent_style=space
indent_size=2
diff --git a/zeppelin-web-angular/.eslintrc.json
b/zeppelin-web-angular/.eslintrc.json
index f1c4784198..683735703c 100644
--- a/zeppelin-web-angular/.eslintrc.json
+++ b/zeppelin-web-angular/.eslintrc.json
@@ -42,7 +42,6 @@
"@typescript-eslint/consistent-type-assertions": "off",
"@typescript-eslint/consistent-type-definitions": "off",
"@typescript-eslint/no-confusing-non-null-assertion": "off",
- "o-empty-function": "off",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/prefer-for-of": "off",
@@ -85,6 +84,13 @@
"@typescript-eslint/naming-convention": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-this-alias": "error",
+ "@typescript-eslint/no-unused-vars": [
+ "error",
+ {
+ "argsIgnorePattern": "^_",
+ "varsIgnorePattern": "^_"
+ }
+ ],
"@typescript-eslint/quotes": "off",
"eol-last": "off",
"import/no-cycle": "error",
diff --git
a/zeppelin-web-angular/e2e/tests/authentication/anonymous-login-redirect.spec.ts
b/zeppelin-web-angular/e2e/tests/authentication/anonymous-login-redirect.spec.ts
index c123a48fb9..1c0905c282 100644
---
a/zeppelin-web-angular/e2e/tests/authentication/anonymous-login-redirect.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/authentication/anonymous-login-redirect.spec.ts
@@ -43,9 +43,7 @@ test.describe('Anonymous User Login Redirect', () => {
await waitForZeppelinReady(page);
});
- test('When accessing login page directly, Then should redirect to home
with proper URL change', async ({
- page
- }) => {
+ test('When accessing login page directly, Then should redirect to home
with proper URL change', async () => {
const redirectResult = await
homePageUtil.verifyAnonymousUserRedirectFromLogin();
expect(redirectResult.isLoginUrlMaintained).toBe(false);
diff --git
a/zeppelin-web-angular/e2e/tests/home/home-page-enhanced-functionality.spec.ts
b/zeppelin-web-angular/e2e/tests/home/home-page-enhanced-functionality.spec.ts
index f6a93c725d..1025a48e4f 100644
---
a/zeppelin-web-angular/e2e/tests/home/home-page-enhanced-functionality.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/home/home-page-enhanced-functionality.spec.ts
@@ -27,32 +27,32 @@ test.describe('Home Page Enhanced Functionality', () => {
});
test.describe('Given documentation links are displayed', () => {
- test('When documentation link is checked Then should have correct version
in URL', async ({ page }) => {
+ test('When documentation link is checked Then should have correct version
in URL', async () => {
await homeUtil.verifyDocumentationVersionLink();
});
- test('When external links are checked Then should all open in new tab',
async ({ page }) => {
+ test('When external links are checked Then should all open in new tab',
async () => {
await homeUtil.verifyAllExternalLinksTargetBlank();
});
});
test.describe('Given welcome section display', () => {
- test('When page loads Then should show welcome content with proper text',
async ({ page }) => {
+ test('When page loads Then should show welcome content with proper text',
async () => {
await homeUtil.verifyWelcomeSection();
});
- test('When welcome section is displayed Then should contain interactive
elements', async ({ page }) => {
+ test('When welcome section is displayed Then should contain interactive
elements', async () => {
await homeUtil.verifyNotebookSection();
});
});
test.describe('Given community section content', () => {
- test('When community section loads Then should display help and community
headings', async ({ page }) => {
+ test('When community section loads Then should display help and community
headings', async () => {
await homeUtil.verifyHelpSection();
await homeUtil.verifyCommunitySection();
});
- test('When external links are displayed Then should show correct targets',
async ({ page }) => {
+ test('When external links are displayed Then should show correct targets',
async () => {
const linkTargets = await homeUtil.testExternalLinkTargets();
expect(linkTargets.documentationHref).toContain('zeppelin.apache.org/docs');
diff --git a/zeppelin-web-angular/e2e/tests/home/home-page-layout.spec.ts
b/zeppelin-web-angular/e2e/tests/home/home-page-layout.spec.ts
index ef2698750c..b830f8ab03 100644
--- a/zeppelin-web-angular/e2e/tests/home/home-page-layout.spec.ts
+++ b/zeppelin-web-angular/e2e/tests/home/home-page-layout.spec.ts
@@ -12,7 +12,6 @@
import { expect, test } from '@playwright/test';
import { HomePage } from '../../models/home-page';
-import { HomePageUtil } from '../../models/home-page.util';
import { addPageAnnotationBeforeEach, performLoginIfRequired,
waitForZeppelinReady, PAGES } from '../../utils';
test.describe('Home Page - Layout and Grid', () => {
@@ -26,8 +25,6 @@ test.describe('Home Page - Layout and Grid', () => {
test.describe('Responsive Grid Layout', () => {
test('should display responsive grid structure', async ({ page }) => {
- const homePageUtil = new HomePageUtil(page);
-
await test.step('Given I am on the home page', async () => {
const homePage = new HomePage(page);
await homePage.navigateToHome();
diff --git
a/zeppelin-web-angular/e2e/tests/home/home-page-note-operations.spec.ts
b/zeppelin-web-angular/e2e/tests/home/home-page-note-operations.spec.ts
index f7be8fd9d6..23a6888054 100644
--- a/zeppelin-web-angular/e2e/tests/home/home-page-note-operations.spec.ts
+++ b/zeppelin-web-angular/e2e/tests/home/home-page-note-operations.spec.ts
@@ -11,16 +11,12 @@
*/
import { expect, test } from '@playwright/test';
-import { HomePage } from '../../models/home-page';
import { addPageAnnotationBeforeEach, performLoginIfRequired,
waitForZeppelinReady, PAGES } from '../../utils';
addPageAnnotationBeforeEach(PAGES.WORKSPACE.HOME);
test.describe('Home Page Note Operations', () => {
- let homePage: HomePage;
-
test.beforeEach(async ({ page }) => {
- homePage = new HomePage(page);
await page.goto('/');
await waitForZeppelinReady(page);
await performLoginIfRequired(page);
@@ -93,13 +89,10 @@ test.describe('Home Page Note Operations', () => {
await page
.waitForFunction(
- () => {
- return (
- document.querySelector('zeppelin-note-rename') !== null ||
- document.querySelector('[role="dialog"]') !== null ||
- document.querySelector('.ant-modal') !== null
- );
- },
+ () =>
+ document.querySelector('zeppelin-note-rename') !== null ||
+ document.querySelector('[role="dialog"]') !== null ||
+ document.querySelector('.ant-modal') !== null,
{ timeout: 5000 }
)
.catch(() => {
diff --git
a/zeppelin-web-angular/e2e/tests/home/home-page-notebook-actions.spec.ts
b/zeppelin-web-angular/e2e/tests/home/home-page-notebook-actions.spec.ts
index c3e7e1388b..c323573b28 100644
--- a/zeppelin-web-angular/e2e/tests/home/home-page-notebook-actions.spec.ts
+++ b/zeppelin-web-angular/e2e/tests/home/home-page-notebook-actions.spec.ts
@@ -10,7 +10,7 @@
* limitations under the License.
*/
-import { expect, test } from '@playwright/test';
+import { test } from '@playwright/test';
import { HomePageUtil } from '../../models/home-page.util';
import { addPageAnnotationBeforeEach, performLoginIfRequired,
waitForZeppelinReady, PAGES } from '../../utils';
@@ -27,21 +27,21 @@ test.describe('Home Page Notebook Actions', () => {
});
test.describe('Given notebook list is displayed', () => {
- test('When page loads Then should show notebook actions', async ({ page })
=> {
+ test('When page loads Then should show notebook actions', async () => {
await homeUtil.verifyNotebookActions();
});
- test('When refresh button is clicked Then should trigger reload with
loading state', async ({ page }) => {
+ test('When refresh button is clicked Then should trigger reload with
loading state', async () => {
await homeUtil.testNotebookRefreshLoadingState();
});
- test('When filter is used Then should filter notebook list', async ({ page
}) => {
+ test('When filter is used Then should filter notebook list', async () => {
await homeUtil.testFilterFunctionality('test');
});
});
test.describe('Given create new note action', () => {
- test('When create new note is clicked Then should open note creation
modal', async ({ page }) => {
+ test('When create new note is clicked Then should open note creation
modal', async () => {
try {
await homeUtil.verifyCreateNewNoteWorkflow();
} catch (error) {
@@ -51,7 +51,7 @@ test.describe('Home Page Notebook Actions', () => {
});
test.describe('Given import note action', () => {
- test('When import note is clicked Then should open import modal', async ({
page }) => {
+ test('When import note is clicked Then should open import modal', async ()
=> {
try {
await homeUtil.verifyImportNoteWorkflow();
} catch (error) {
@@ -61,7 +61,7 @@ test.describe('Home Page Notebook Actions', () => {
});
test.describe('Given notebook refresh functionality', () => {
- test('When refresh is triggered Then should maintain notebook list
visibility', async ({ page }) => {
+ test('When refresh is triggered Then should maintain notebook list
visibility', async () => {
await homeUtil.verifyNotebookRefreshFunctionality();
});
});
diff --git a/zeppelin-web-angular/e2e/tests/theme/dark-mode.spec.ts
b/zeppelin-web-angular/e2e/tests/theme/dark-mode.spec.ts
index aac56d589c..2099180632 100644
--- a/zeppelin-web-angular/e2e/tests/theme/dark-mode.spec.ts
+++ b/zeppelin-web-angular/e2e/tests/theme/dark-mode.spec.ts
@@ -81,7 +81,7 @@ test.describe('Dark Mode Theme Switching', () => {
});
});
- test('Scenario: System Theme and Local Storage Interaction', async ({ page,
context }) => {
+ test('Scenario: System Theme and Local Storage Interaction', async ({ page
}) => {
// Ensure localStorage is clear for each sub-scenario
await themePage.clearLocalStorage();
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-display.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-display.spec.ts
index a8cd35ff10..342c67e7a8 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-display.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-display.spec.ts
@@ -12,7 +12,6 @@
import { expect, test } from '@playwright/test';
import { NotebookReposPage, NotebookRepoItemPage } from
'../../../models/notebook-repos-page';
-import { NotebookRepoItemUtil } from
'../../../models/notebook-repos-page.util';
import { addPageAnnotationBeforeEach, performLoginIfRequired,
waitForZeppelinReady, PAGES } from '../../../utils';
test.describe('Notebook Repository Item - Display Mode', () => {
@@ -20,7 +19,6 @@ test.describe('Notebook Repository Item - Display Mode', ()
=> {
let notebookReposPage: NotebookReposPage;
let repoItemPage: NotebookRepoItemPage;
- let repoItemUtil: NotebookRepoItemUtil;
let firstRepoName: string;
test.beforeEach(async ({ page }) => {
@@ -33,7 +31,6 @@ test.describe('Notebook Repository Item - Display Mode', ()
=> {
const firstCard = notebookReposPage.repositoryItems.first();
firstRepoName = (await
firstCard.locator('.ant-card-head-title').textContent()) || '';
repoItemPage = new NotebookRepoItemPage(page, firstRepoName);
- repoItemUtil = new NotebookRepoItemUtil(page, firstRepoName);
});
test('should display repository card with name', async () => {
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
index 2db38ea6ae..51f5d232c1 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
@@ -12,7 +12,6 @@
import { expect, test } from '@playwright/test';
import { NotebookReposPage, NotebookRepoItemPage } from
'../../../models/notebook-repos-page';
-import { NotebookRepoItemUtil } from
'../../../models/notebook-repos-page.util';
import { addPageAnnotationBeforeEach, performLoginIfRequired,
waitForZeppelinReady, PAGES } from '../../../utils';
test.describe('Notebook Repository Item - Form Validation', () => {
@@ -20,7 +19,6 @@ test.describe('Notebook Repository Item - Form Validation',
() => {
let notebookReposPage: NotebookReposPage;
let repoItemPage: NotebookRepoItemPage;
- let repoItemUtil: NotebookRepoItemUtil;
let firstRepoName: string;
test.beforeEach(async ({ page }) => {
@@ -33,7 +31,6 @@ test.describe('Notebook Repository Item - Form Validation',
() => {
const firstCard = notebookReposPage.repositoryItems.first();
firstRepoName = (await
firstCard.locator('.ant-card-head-title').textContent()) || '';
repoItemPage = new NotebookRepoItemPage(page, firstRepoName);
- repoItemUtil = new NotebookRepoItemUtil(page, firstRepoName);
});
test('should disable save button when form is invalid', async () => {
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
index 1dfb115afe..e25fbfd911 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
@@ -12,7 +12,6 @@
import { expect, test } from '@playwright/test';
import { NotebookReposPage, NotebookRepoItemPage } from
'../../../models/notebook-repos-page';
-import { NotebookRepoItemUtil } from
'../../../models/notebook-repos-page.util';
import { addPageAnnotationBeforeEach, performLoginIfRequired,
waitForZeppelinReady, PAGES } from '../../../utils';
test.describe('Notebook Repository Item - Settings', () => {
@@ -20,7 +19,6 @@ test.describe('Notebook Repository Item - Settings', () => {
let notebookReposPage: NotebookReposPage;
let repoItemPage: NotebookRepoItemPage;
- let repoItemUtil: NotebookRepoItemUtil;
let firstRepoName: string;
test.beforeEach(async ({ page }) => {
@@ -33,7 +31,6 @@ test.describe('Notebook Repository Item - Settings', () => {
const firstCard = notebookReposPage.repositoryItems.first();
firstRepoName = (await
firstCard.locator('.ant-card-head-title').textContent()) || '';
repoItemPage = new NotebookRepoItemPage(page, firstRepoName);
- repoItemUtil = new NotebookRepoItemUtil(page, firstRepoName);
});
test('should display settings table with headers', async () => {
diff --git a/zeppelin-web-angular/e2e/tsconfig.json
b/zeppelin-web-angular/e2e/tsconfig.json
index 27519e44d3..efa266ca08 100644
--- a/zeppelin-web-angular/e2e/tsconfig.json
+++ b/zeppelin-web-angular/e2e/tsconfig.json
@@ -1,8 +1,12 @@
{
+ "extends": "../tsconfig.base.json",
"compilerOptions": {
"baseUrl": ".",
"paths": {
"e2e/*": ["./*"]
- }
- }
+ },
+ "noUnusedParameters": true,
+ "noUnusedLocals": true
+ },
+ "include": ["**/*.ts"]
}
diff --git a/zeppelin-web-angular/e2e/utils.ts
b/zeppelin-web-angular/e2e/utils.ts
index 36d09a8b7e..0ba6032933 100644
--- a/zeppelin-web-angular/e2e/utils.ts
+++ b/zeppelin-web-angular/e2e/utils.ts
@@ -10,9 +10,8 @@
* limitations under the License.
*/
-import { expect, test, Page, TestInfo } from '@playwright/test';
+import { test, Page, TestInfo } from '@playwright/test';
import { LoginTestUtil } from './models/login-page.util';
-import { NotebookUtil } from './models/notebook.util';
export const PAGES = {
// Main App
diff --git
a/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts
b/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts
index 8dbfe8ad90..b898e697f3 100644
---
a/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts
+++
b/zeppelin-web-angular/projects/zeppelin-visualization/src/g2-visualization-component-base.ts
@@ -41,7 +41,7 @@ export abstract class G2VisualizationComponentBase implements
OnDestroy {
this.renderAfter(this.config);
}
- renderAfter(config: GraphConfig): void {}
+ renderAfter(_config: GraphConfig): void {}
getKey(): string {
if (!this.config) {
diff --git a/zeppelin-web-angular/src/app/core/paragraph-base/paragraph-base.ts
b/zeppelin-web-angular/src/app/core/paragraph-base/paragraph-base.ts
index fca72b174f..4e7c0e0fde 100644
--- a/zeppelin-web-angular/src/app/core/paragraph-base/paragraph-base.ts
+++ b/zeppelin-web-angular/src/app/core/paragraph-base/paragraph-base.ts
@@ -23,8 +23,7 @@ import {
ParagraphConfigResults,
ParagraphEditorSetting,
ParagraphItem,
- ParagraphIResultsMsgItem,
- ParagraphResults
+ ParagraphIResultsMsgItem
} from '@zeppelin/sdk';
import * as DiffMatchPatch from 'diff-match-patch';
@@ -339,7 +338,7 @@ export abstract class ParagraphBase extends
MessageListenersManager {
}
}
- runParagraphUsingSpell(paragraphText: string, magic: string, propagated:
boolean) {
+ runParagraphUsingSpell(_paragraphText: string, _magic: string, _propagated:
boolean) {
// TODO(hsuanxyz)
}
diff --git a/zeppelin-web-angular/src/app/pages/login/login.guard.ts
b/zeppelin-web-angular/src/app/pages/login/login.guard.ts
index 960db4f418..aa5d3efe76 100644
--- a/zeppelin-web-angular/src/app/pages/login/login.guard.ts
+++ b/zeppelin-web-angular/src/app/pages/login/login.guard.ts
@@ -11,7 +11,7 @@
*/
import { Injectable } from '@angular/core';
-import { CanActivate, Router, UrlTree } from '@angular/router';
+import { CanActivate, Router } from '@angular/router';
import { of, Observable } from 'rxjs';
import { catchError, map } from 'rxjs/operators';
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/home/home.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/home/home.component.ts
index 7bdf4fa4d2..cc2a8e6d57 100644
--- a/zeppelin-web-angular/src/app/pages/workspace/home/home.component.ts
+++ b/zeppelin-web-angular/src/app/pages/workspace/home/home.component.ts
@@ -31,7 +31,7 @@ export class HomeComponent extends MessageListenersManager
implements OnInit {
}
@MessageListener(OP.NOTES_INFO)
- getNotes(data: MessageReceiveDataTypeMap[OP.NOTES_INFO]) {
+ getNotes(_data: MessageReceiveDataTypeMap[OP.NOTES_INFO]) {
this.loading = false;
this.cdr.markForCheck();
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/job-manager/job-manager.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/job-manager/job-manager.component.ts
index 78a3fdbdbf..7762ce4069 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/job-manager/job-manager.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/job-manager/job-manager.component.ts
@@ -10,7 +10,7 @@
* limitations under the License.
*/
-import { ChangeDetectionStrategy, ChangeDetectorRef, Component, OnDestroy,
OnInit } from '@angular/core';
+import { ChangeDetectionStrategy, ChangeDetectorRef, Component, OnDestroy }
from '@angular/core';
import { FormBuilder, FormGroup } from '@angular/forms';
import { NzModalService } from 'ng-zorro-antd/modal';
@@ -73,7 +73,7 @@ export class JobManagerComponent extends
MessageListenersManager implements OnDe
}
@MessageListener(OP.JOB_MANAGER_DISABLED)
- onJobManagerDisabled(data: JobManagerDisabled) {
+ onJobManagerDisabled(_data: JobManagerDisabled) {
this.status = 'disabled';
this.cdr.markForCheck();
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/job-manager/job/job.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/job-manager/job/job.component.ts
index 908976805c..2724ef5c9f 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/job-manager/job/job.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/job-manager/job/job.component.ts
@@ -75,7 +75,7 @@ export class JobManagerJobComponent implements OnInit,
OnChanges {
ngOnInit() {}
- ngOnChanges(changes: SimpleChanges): void {
+ ngOnChanges(_changes: SimpleChanges): void {
this.setIcon();
this.setRelativeTime();
this.setProgress();
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts
index 839aa2d3ee..4d3cbe86c6 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts
@@ -127,7 +127,7 @@ export class NotebookActionBarComponent extends
MessageListenersManager implemen
}
@MessageListener(OP.PARAGRAPH)
- paragraphUpdate(data: MessageReceiveDataTypeMap[OP.PARAGRAPH]) {
+ paragraphUpdate(_data: MessageReceiveDataTypeMap[OP.PARAGRAPH]) {
this.updateIsNoteParagraphRunning();
this.cdr.markForCheck();
}
@@ -238,16 +238,16 @@ export class NotebookActionBarComponent extends
MessageListenersManager implemen
}
// TODO: Implement logic to find the previous search match in the notebook
editor
- onFindPrevClick(searchText: string) {}
+ onFindPrevClick(_searchText: string) {}
// TODO: Implement logic to find the next search match in the notebook editor
- onFindNextClick(searchText: string) {}
+ onFindNextClick(_searchText: string) {}
// TODO: Implement logic to replace the current search match with the
replacement text
- onReplaceClick(searchText: string, replaceText: string) {}
+ onReplaceClick(_searchText: string, _replaceText: string) {}
// TODO: Implement logic to replace all search matches with the replacement
text
- onReplaceAllClick(searchText: string, replaceText: string) {
+ onReplaceAllClick(searchText: string, _replaceText: string) {
this.handleSearch.emit(searchText);
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/notebook/interpreter-binding/interpreter-binding.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/notebook/interpreter-binding/interpreter-binding.component.ts
index de1e04411f..7f1cc8e1de 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/notebook/interpreter-binding/interpreter-binding.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/notebook/interpreter-binding/interpreter-binding.component.ts
@@ -42,7 +42,7 @@ export class NotebookInterpreterBindingComponent {
new Promise(resolve => {
this.restarting = true;
this.interpreterService.restartInterpreter(interpreter.id,
this.noteId).subscribe(
- data => {
+ _data => {
this.restarting = false;
this.cdr.markForCheck();
resolve();
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts
index 791c2e0c0a..b22cd012d3 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts
@@ -182,7 +182,7 @@ export class NotebookComponent extends
MessageListenersManager implements OnInit
}
@MessageListener(OP.SET_NOTE_REVISION)
- setNoteRevision(data: MessageReceiveDataTypeMap[OP.SET_NOTE_REVISION]) {
+ setNoteRevision(_data: MessageReceiveDataTypeMap[OP.SET_NOTE_REVISION]) {
const { noteId } = this.activatedRoute.snapshot.params;
this.router.navigate(['/notebook', noteId]).then();
}
@@ -218,7 +218,7 @@ export class NotebookComponent extends
MessageListenersManager implements OnInit
}
@MessageListener(OP.PATCH_PARAGRAPH)
- patchParagraph(data: MessageReceiveDataTypeMap[OP.PATCH_PARAGRAPH]) {
+ patchParagraph(_data: MessageReceiveDataTypeMap[OP.PATCH_PARAGRAPH]) {
this.collaborativeMode = true;
this.cdr.markForCheck();
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/published/paragraph/paragraph.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/published/paragraph/paragraph.component.ts
index 8022e344c8..0e8ae76642 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/published/paragraph/paragraph.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/published/paragraph/paragraph.component.ts
@@ -115,7 +115,7 @@ export class PublishedParagraphComponent extends
ParagraphBase implements Publis
}
}
- changeColWidth(needCommit: boolean, updateResult?: boolean): void {
+ changeColWidth(_needCommit: boolean, _updateResult?: boolean): void {
// noop
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/share/dynamic-forms/dynamic-forms.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/share/dynamic-forms/dynamic-forms.component.ts
index 72bd4d55eb..aebe92e44a 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/share/dynamic-forms/dynamic-forms.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/share/dynamic-forms/dynamic-forms.component.ts
@@ -111,7 +111,7 @@ export class NotebookParagraphDynamicFormsComponent
implements OnInit, OnChanges
this.formChange$.pipe(debounceTime(800),
takeUntil(this.destroy$)).subscribe(() => this.formChange.emit());
}
- ngOnChanges(changes: SimpleChanges): void {
+ ngOnChanges(_changes: SimpleChanges): void {
this.setForms();
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts
b/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts
index 71f9d6ea66..600124e92a 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts
+++
b/zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts
@@ -32,7 +32,7 @@ import { cloneDeep, isEqual } from 'lodash';
import { NzResizeEvent } from 'ng-zorro-antd/resizable';
import { Subject, Subscription } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
-import { utils, writeFile, WorkSheet, WritingOptions } from 'xlsx';
+import { utils, writeFile, WritingOptions } from 'xlsx';
import {
DatasetType,
diff --git a/zeppelin-web-angular/src/app/services/helium.service.ts
b/zeppelin-web-angular/src/app/services/helium.service.ts
index 7e9612e4a8..84fe126e2f 100644
--- a/zeppelin-web-angular/src/app/services/helium.service.ts
+++ b/zeppelin-web-angular/src/app/services/helium.service.ts
@@ -35,7 +35,7 @@ export class HeliumService extends BaseRest {
return this.visualizationBundles$.asObservable();
}
- getSpellByMagic(magic: string): string | null {
+ getSpellByMagic(_magic: string): string | null {
return null;
}
diff --git
a/zeppelin-web-angular/src/app/visualizations/pie-chart/pie-chart-visualization.component.ts
b/zeppelin-web-angular/src/app/visualizations/pie-chart/pie-chart-visualization.component.ts
index c059239405..2064309350 100644
---
a/zeppelin-web-angular/src/app/visualizations/pie-chart/pie-chart-visualization.component.ts
+++
b/zeppelin-web-angular/src/app/visualizations/pie-chart/pie-chart-visualization.component.ts
@@ -43,7 +43,7 @@ export class PieChartVisualizationComponent extends
G2VisualizationComponentBase
ngOnInit() {}
- refreshSetting(config: GraphConfig) {
+ refreshSetting(_config: GraphConfig) {
this.pivotSettingComponent.init();
}
diff --git
a/zeppelin-web-angular/src/app/visualizations/scatter-chart/scatter-chart-visualization.component.ts
b/zeppelin-web-angular/src/app/visualizations/scatter-chart/scatter-chart-visualization.component.ts
index 93ecb39db2..392ecb6e47 100644
---
a/zeppelin-web-angular/src/app/visualizations/scatter-chart/scatter-chart-visualization.component.ts
+++
b/zeppelin-web-angular/src/app/visualizations/scatter-chart/scatter-chart-visualization.component.ts
@@ -48,7 +48,7 @@ export class ScatterChartVisualizationComponent extends
G2VisualizationComponent
super(visualization);
}
- refreshSetting(config: GraphConfig) {
+ refreshSetting(_config: GraphConfig) {
this.scatterSettingComponent.init();
this.cdr.markForCheck();
}
