This is an automated email from the ASF dual-hosted git repository.
chanholee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new bf62a2a25f [HOTFIX] @playwright/test 1.56.1 to 1.55.1
bf62a2a25f is described below
commit bf62a2a25f460aaaa4794f82a0b52553187eeb7f
Author: YONGJAE LEE(이용재) <[email protected]>
AuthorDate: Tue Nov 4 00:15:55 2025 +0900
[HOTFIX] @playwright/test 1.56.1 to 1.55.1
### What is this PR for?
https://github.com/apache/zeppelin/pull/5111#issuecomment-3480683038
#5108
After upgrading Playwright to the latest version(1.53.2 to 1.56.1), several
test cases started failing on WebKit. The issue was resolved by rolling back to
the previous minor version(1.55.1).
[related issue]
https://github.com/microsoft/playwright/issues/37766
### What type of PR is it?
Hot Fix
### Todos
### What is the Jira issue?
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #5115 from dididy/fix/e2e.
Signed-off-by: ChanHo Lee <[email protected]>
---
.../notebook-repos/notebook-repo-item-edit.spec.ts | 6 +--
.../notebook-repo-item-form-validation.spec.ts | 18 ++------
.../notebook-repo-item-settings.spec.ts | 18 ++------
.../notebook-repo-item-workflow.spec.ts | 12 +-----
zeppelin-web-angular/package-lock.json | 50 ++++++++++++----------
zeppelin-web-angular/package.json | 2 +-
6 files changed, 37 insertions(+), 69 deletions(-)
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts
index 597f5ff191..13c870df38 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts
@@ -73,11 +73,7 @@ test.describe('Notebook Repository Item - Edit Mode', () => {
}
const firstRow = repoItemPage.settingRows.first();
- const settingName =
- (await firstRow
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await firstRow.locator('td').first().textContent())
|| '';
const originalValue = await repoItemPage.getSettingValue(settingName);
await repoItemPage.clickEdit();
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
index 69f9367e6b..2db38ea6ae 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
@@ -46,11 +46,7 @@ test.describe('Notebook Repository Item - Form Validation',
() => {
await repoItemPage.clickEdit();
const firstRow = repoItemPage.settingRows.first();
- const settingName =
- (await firstRow
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await firstRow.locator('td').first().textContent())
|| '';
const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
@@ -73,11 +69,7 @@ test.describe('Notebook Repository Item - Form Validation',
() => {
await repoItemPage.clickEdit();
const firstRow = repoItemPage.settingRows.first();
- const settingName =
- (await firstRow
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await firstRow.locator('td').first().textContent())
|| '';
const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
@@ -102,11 +94,7 @@ test.describe('Notebook Repository Item - Form Validation',
() => {
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
- const settingName =
- (await row
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await row.locator('td').first().textContent()) ||
'';
const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
index 905074ba13..1dfb115afe 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
@@ -60,11 +60,7 @@ test.describe('Notebook Repository Item - Settings', () => {
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
- const settingName =
- (await row
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await row.locator('td').first().textContent()) ||
'';
const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
@@ -86,11 +82,7 @@ test.describe('Notebook Repository Item - Settings', () => {
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
- const settingName =
- (await row
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await row.locator('td').first().textContent()) ||
'';
const isDropdownVisible = await
repoItemPage.isDropdownVisible(settingName);
if (isDropdownVisible) {
@@ -112,11 +104,7 @@ test.describe('Notebook Repository Item - Settings', () =>
{
let foundInput = false;
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
- const settingName =
- (await row
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await row.locator('td').first().textContent()) ||
'';
const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
diff --git
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts
index c730ea3d2c..a765eb82dd 100644
---
a/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts
+++
b/zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts
@@ -51,11 +51,7 @@ test.describe('Notebook Repository Item - Edit Workflow', ()
=> {
let foundSetting = false;
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
- const settingName =
- (await row
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await row.locator('td').first().textContent()) ||
'';
const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
@@ -91,11 +87,7 @@ test.describe('Notebook Repository Item - Edit Workflow', ()
=> {
await repoItemUtil.verifyDisplayMode();
const firstRow = repoItemPage.settingRows.first();
- const settingName =
- (await firstRow
- .locator('td')
- .first()
- .textContent()) || '';
+ const settingName = (await firstRow.locator('td').first().textContent())
|| '';
const originalValue = await repoItemPage.getSettingValue(settingName);
await repoItemPage.clickEdit();
diff --git a/zeppelin-web-angular/package-lock.json
b/zeppelin-web-angular/package-lock.json
index 6a4810e5b1..4c689afa24 100644
--- a/zeppelin-web-angular/package-lock.json
+++ b/zeppelin-web-angular/package-lock.json
@@ -52,7 +52,7 @@
"@angular/cli": "~13.3.11",
"@angular/compiler-cli": "~13.4.0",
"@angular/language-service": "~13.4.0",
- "@playwright/test": "1.56.1",
+ "@playwright/test": "1.55.1",
"@types/angular": "^1.8.0",
"@types/diff-match-patch": "^1.0.36",
"@types/highlight.js": "^9.12.3",
@@ -4073,12 +4073,13 @@
}
},
"node_modules/@playwright/test": {
- "version": "1.56.1",
- "resolved":
"https://registry.npmjs.org/@playwright/test/-/test-1.56.1.tgz";,
- "integrity":
"sha512-vSMYtL/zOcFpvJCW71Q/OEGQb7KYBPAdKh35WNSkaZA75JlAO8ED8UN6GUNTm3drWomcbcqRPFqQbLae8yBTdg==",
+ "version": "1.55.1",
+ "resolved":
"https://registry.npmjs.org/@playwright/test/-/test-1.55.1.tgz";,
+ "integrity":
"sha512-IVAh/nOJaw6W9g+RJVlIQJ6gSiER+ae6mKQ5CX1bERzQgbC1VSeBlwdvczT7pxb0GWiyrxH4TGKbMfDb4Sq/ig==",
"dev": true,
+ "license": "Apache-2.0",
"dependencies": {
- "playwright": "1.56.1"
+ "playwright": "1.55.1"
},
"bin": {
"playwright": "cli.js"
@@ -13865,12 +13866,13 @@
}
},
"node_modules/playwright": {
- "version": "1.56.1",
- "resolved":
"https://registry.npmjs.org/playwright/-/playwright-1.56.1.tgz";,
- "integrity":
"sha512-aFi5B0WovBHTEvpM3DzXTUaeN6eN0qWnTkKx4NQaH4Wvcmc153PdaY2UBdSYKaGYw+UyWXSVyxDUg5DoPEttjw==",
+ "version": "1.55.1",
+ "resolved":
"https://registry.npmjs.org/playwright/-/playwright-1.55.1.tgz";,
+ "integrity":
"sha512-cJW4Xd/G3v5ovXtJJ52MAOclqeac9S/aGGgRzLabuF8TnIb6xHvMzKIa6JmrRzUkeXJgfL1MhukP0NK6l39h3A==",
"dev": true,
+ "license": "Apache-2.0",
"dependencies": {
- "playwright-core": "1.56.1"
+ "playwright-core": "1.55.1"
},
"bin": {
"playwright": "cli.js"
@@ -13883,10 +13885,11 @@
}
},
"node_modules/playwright-core": {
- "version": "1.56.1",
- "resolved":
"https://registry.npmjs.org/playwright-core/-/playwright-core-1.56.1.tgz";,
- "integrity":
"sha512-hutraynyn31F+Bifme+Ps9Vq59hKuUCz7H1kDOcBs+2oGguKkWTU50bBWrtz34OUWmIwpBTWDxaRPXrIXkgvmQ==",
+ "version": "1.55.1",
+ "resolved":
"https://registry.npmjs.org/playwright-core/-/playwright-core-1.55.1.tgz";,
+ "integrity":
"sha512-Z6Mh9mkwX+zxSlHqdr5AOcJnfp+xUWLCt9uKV18fhzA8eyxUd8NUWzAjxUh55RZKSYwDGX0cfaySdhZJGMoJ+w==",
"dev": true,
+ "license": "Apache-2.0",
"bin": {
"playwright-core": "cli.js"
},
@@ -13900,6 +13903,7 @@
"integrity":
"sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==",
"dev": true,
"hasInstallScript": true,
+ "license": "MIT",
"optional": true,
"os": [
"darwin"
@@ -20901,12 +20905,12 @@
}
},
"@playwright/test": {
- "version": "1.56.1",
- "resolved":
"https://registry.npmjs.org/@playwright/test/-/test-1.56.1.tgz";,
- "integrity":
"sha512-vSMYtL/zOcFpvJCW71Q/OEGQb7KYBPAdKh35WNSkaZA75JlAO8ED8UN6GUNTm3drWomcbcqRPFqQbLae8yBTdg==",
+ "version": "1.55.1",
+ "resolved":
"https://registry.npmjs.org/@playwright/test/-/test-1.55.1.tgz";,
+ "integrity":
"sha512-IVAh/nOJaw6W9g+RJVlIQJ6gSiER+ae6mKQ5CX1bERzQgbC1VSeBlwdvczT7pxb0GWiyrxH4TGKbMfDb4Sq/ig==",
"dev": true,
"requires": {
- "playwright": "1.56.1"
+ "playwright": "1.55.1"
}
},
"@rollup/plugin-json": {
@@ -28070,13 +28074,13 @@
}
},
"playwright": {
- "version": "1.56.1",
- "resolved":
"https://registry.npmjs.org/playwright/-/playwright-1.56.1.tgz";,
- "integrity":
"sha512-aFi5B0WovBHTEvpM3DzXTUaeN6eN0qWnTkKx4NQaH4Wvcmc153PdaY2UBdSYKaGYw+UyWXSVyxDUg5DoPEttjw==",
+ "version": "1.55.1",
+ "resolved":
"https://registry.npmjs.org/playwright/-/playwright-1.55.1.tgz";,
+ "integrity":
"sha512-cJW4Xd/G3v5ovXtJJ52MAOclqeac9S/aGGgRzLabuF8TnIb6xHvMzKIa6JmrRzUkeXJgfL1MhukP0NK6l39h3A==",
"dev": true,
"requires": {
"fsevents": "2.3.2",
- "playwright-core": "1.56.1"
+ "playwright-core": "1.55.1"
},
"dependencies": {
"fsevents": {
@@ -28089,9 +28093,9 @@
}
},
"playwright-core": {
- "version": "1.56.1",
- "resolved":
"https://registry.npmjs.org/playwright-core/-/playwright-core-1.56.1.tgz";,
- "integrity":
"sha512-hutraynyn31F+Bifme+Ps9Vq59hKuUCz7H1kDOcBs+2oGguKkWTU50bBWrtz34OUWmIwpBTWDxaRPXrIXkgvmQ==",
+ "version": "1.55.1",
+ "resolved":
"https://registry.npmjs.org/playwright-core/-/playwright-core-1.55.1.tgz";,
+ "integrity":
"sha512-Z6Mh9mkwX+zxSlHqdr5AOcJnfp+xUWLCt9uKV18fhzA8eyxUd8NUWzAjxUh55RZKSYwDGX0cfaySdhZJGMoJ+w==",
"dev": true
},
"point-at-length": {
diff --git a/zeppelin-web-angular/package.json
b/zeppelin-web-angular/package.json
index 392e3a4235..c12b284e41 100644
--- a/zeppelin-web-angular/package.json
+++ b/zeppelin-web-angular/package.json
@@ -69,7 +69,7 @@
"@angular/cli": "~13.3.11",
"@angular/compiler-cli": "~13.4.0",
"@angular/language-service": "~13.4.0",
- "@playwright/test": "1.56.1",
+ "@playwright/test": "1.55.1",
"@types/angular": "^1.8.0",
"@types/diff-match-patch": "^1.0.36",
"@types/highlight.js": "^9.12.3",
