This is an automated email from the ASF dual-hosted git repository.

chanholee pushed a commit to branch branch-0.12
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.12 by this push:
     new 7686b9ce2b [ZEPPELIN-6338] Allow separate frontend modules to use 
different Node/NPM versions
7686b9ce2b is described below

commit 7686b9ce2b7982e47ead87f2fafb484fafbda6d6
Author: ChanHo Lee <[email protected]>
AuthorDate: Sun Sep 28 12:50:19 2025 +0900

    [ZEPPELIN-6338] Allow separate frontend modules to use different Node/NPM 
versions
    
    ### What is this PR for?
    Moved the `node.version` and `npm.version` properties from the parent 
`pom.xml` to each module's `pom.xml`.
    This allows `zeppelin-web` and `zeppelin-web-angular` to manage their 
Node/NPM versions independently.
    
    Note: Each module installs and manages its own Node/NPM, so this change 
simply makes that independence explicit without adding extra maintenance burden 
or increasing package size.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-6338
    
    ### How should this be tested?
    Check CIs if Node and npm is installed for both modules.
    
    ### Questions:
    * Does the license files need to update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Closes #5084 from tbonelee/update-nodejs.
    
    Signed-off-by: ChanHo Lee <[email protected]>
    (cherry picked from commit 8fd90cf8f6a92ad58454023a88ca0468839da3aa)
    Signed-off-by: ChanHo Lee <[email protected]>
---
 pom.xml                      | 4 +---
 zeppelin-web-angular/pom.xml | 8 +++++---
 zeppelin-web/pom.xml         | 2 ++
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/pom.xml b/pom.xml
index 77ed4f0748..a992a32cc0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -107,9 +107,7 @@
     <scalatest.version>3.2.19</scalatest.version>
     <scalacheck.version>1.18.1</scalacheck.version>
 
-    <!-- frontend maven plugin related versions-->
-    <node.version>v16.20.2</node.version>
-    <npm.version>8.19.4</npm.version>
+    <!-- frontend maven plugin version-->
     <plugin.frontend.version>1.12.1</plugin.frontend.version>
 
     <!-- common library versions -->
diff --git a/zeppelin-web-angular/pom.xml b/zeppelin-web-angular/pom.xml
index c087c04503..488ff17244 100644
--- a/zeppelin-web-angular/pom.xml
+++ b/zeppelin-web-angular/pom.xml
@@ -39,8 +39,10 @@
     <!--plugin versions-->
     
<plugin.frontend.nodeDownloadRoot>https://nodejs.org/dist/</plugin.frontend.nodeDownloadRoot>
     
<plugin.frontend.npmDownloadRoot>https://registry.npmjs.org/npm/-/</plugin.frontend.npmDownloadRoot>
+    <node.version>v16.20.2</node.version>
+    <npm.version>8.19.4</npm.version>
   </properties>
-  
+
   <dependencies>
     <dependency>
       <groupId>org.apache.zeppelin</groupId>
@@ -63,7 +65,7 @@
 
       <plugin>
         <groupId>com.github.eirslett</groupId>
-        <artifactId>frontend-maven-plugin</artifactId>        
+        <artifactId>frontend-maven-plugin</artifactId>
         <configuration>
           
<nodeDownloadRoot>${plugin.frontend.nodeDownloadRoot}</nodeDownloadRoot>
           <npmDownloadRoot>${plugin.frontend.npmDownloadRoot}</npmDownloadRoot>
@@ -236,7 +238,7 @@
       </plugin>
     </plugins>
   </build>
-    
+
   <profiles>
     <profile>
       <id>web-e2e</id>
diff --git a/zeppelin-web/pom.xml b/zeppelin-web/pom.xml
index 75d0119a95..3dfb3a9da8 100644
--- a/zeppelin-web/pom.xml
+++ b/zeppelin-web/pom.xml
@@ -39,6 +39,8 @@
     <!--plugin versions-->
     
<plugin.frontend.nodeDownloadRoot>https://nodejs.org/dist/</plugin.frontend.nodeDownloadRoot>
     
<plugin.frontend.npmDownloadRoot>https://registry.npmjs.org/npm/-/</plugin.frontend.npmDownloadRoot>
+    <node.version>v16.20.2</node.version>
+    <npm.version>8.19.4</npm.version>
     <!-- the scope of the Hadoop dependencies is the same as for the other 
Zeppelin components -->
     <hadoop.deps.scope>test</hadoop.deps.scope>
   </properties>

Reply via email to