This is an automated email from the ASF dual-hosted git repository.
gyeongtae pushed a commit to branch branch-0.12
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/branch-0.12 by this push:
new 23b89a8d3e [ZEPPELIN-6273] Add unit test for AngularInterpreter
23b89a8d3e is described below
commit 23b89a8d3e06f07ef84e9239568064f34f2b2e86
Author: Juyeon <[email protected]>
AuthorDate: Mon Aug 25 20:17:16 2025 +0900
[ZEPPELIN-6273] Add unit test for AngularInterpreter
### What is this PR for?
Since there is currently no test class that can test AngularInterpreter, I
added unit tests for `org.apache.zeppelin.angular.AngularInterpreter` to cover
the core behavior.
- Verify interpret echoes input with Type.ANGULAR and Code.SUCCESS
- Verify empty input returns Type.ANGULAR with empty data
- Verify cancel does not throw
- Verify completion returns empty list
- Verify getFormType() returns FormType.NATIVE
- Verify getProgress() returns 0
- Verify scheduler is FIFOScheduler and name contains AngularInterpreter
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6273
### How should this be tested?
* In the angular module, run test.
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #5021 from proceane/feature/ZEPPELIN-6273.
Signed-off-by: ParkGyeongTae <[email protected]>
(cherry picked from commit 53fe7c123befbdd8e09dbc30bfff8dbefd2deb20)
Signed-off-by: ParkGyeongTae <[email protected]>
---
.../zeppelin/angular/AngularInterpreterTest.java | 104 +++++++++++++++++++++
1 file changed, 104 insertions(+)
diff --git
a/angular/src/test/java/org/apache/zeppelin/angular/AngularInterpreterTest.java
b/angular/src/test/java/org/apache/zeppelin/angular/AngularInterpreterTest.java
new file mode 100644
index 0000000000..047decda57
--- /dev/null
+++
b/angular/src/test/java/org/apache/zeppelin/angular/AngularInterpreterTest.java
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.angular;
+
+import org.apache.zeppelin.interpreter.Interpreter;
+import org.apache.zeppelin.interpreter.InterpreterContext;
+import org.apache.zeppelin.interpreter.InterpreterResult;
+import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion;
+import org.apache.zeppelin.scheduler.FIFOScheduler;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+import java.util.Properties;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class AngularInterpreterTest {
+
+ private AngularInterpreter angular;
+ private InterpreterContext context;
+
+ @BeforeEach
+ void setUp() {
+ Properties p = new Properties();
+ angular = new AngularInterpreter(p);
+ angular.open();
+ context = InterpreterContext.builder()
+ .setParagraphId("paragraphId")
+ .build();
+ }
+
+ @AfterEach
+ void tearDown() {
+ if (angular != null) {
+ angular.close();
+ }
+ }
+
+ @Test
+ void testInterpret() {
+ String input = "<div>{{value}}</div>\n<span ng-if=\"cond\">ok</span>";
+ InterpreterResult res = angular.interpret(input, context);
+
+ assertEquals(InterpreterResult.Code.SUCCESS, res.code());
+ assertEquals(1, res.message().size());
+ assertEquals(InterpreterResult.Type.ANGULAR,
res.message().get(0).getType());
+ assertEquals(input, res.message().get(0).getData());
+ }
+
+ @Test
+ void testEmptyStringIsSuccess() {
+ InterpreterResult res = angular.interpret("", context);
+
+ assertEquals(InterpreterResult.Code.SUCCESS, res.code());
+ assertEquals(InterpreterResult.Type.ANGULAR,
res.message().get(0).getType());
+ assertEquals("", res.message().get(0).getData());
+ }
+
+ @Test
+ void testCancelNotThrow() {
+ assertDoesNotThrow(() -> angular.cancel(context));
+ }
+
+ @Test
+ void testCompletionIsEmpty() {
+ List<InterpreterCompletion> comps = angular.completion("{{value}}", 3,
context);
+ assertTrue(comps.isEmpty());
+ }
+
+ @Test
+ void testFormTypeIsNative() {
+ assertEquals(Interpreter.FormType.NATIVE, angular.getFormType());
+ }
+
+ @Test
+ void testProgressIsZero() {
+ assertEquals(0, angular.getProgress(context));
+ }
+
+ @Test
+ void testSchedulerIsFIFOSchedulerInstance() {
+ assertTrue(angular.getScheduler() instanceof FIFOScheduler);
+
assertTrue(angular.getScheduler().getName().contains(AngularInterpreter.class.getName()));
+ }
+}
