(zeppelin) branch master updated: [ZEPPELIN-6288] Replace Yoda conditions in InterpreterFactory with standard null checks

[pdallig]

This is an automated email from the ASF dual-hosted git repository.

pdallig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new f32b50fcc1 [ZEPPELIN-6288] Replace Yoda conditions in 
InterpreterFactory with standard null checks
f32b50fcc1 is described below

commit f32b50fcc1c897e72198da6ffba8a47576d199af
Author: 강현욱 <43662405+hyu...@users.noreply.github.com>
AuthorDate: Fri Aug 22 17:14:14 2025 +0900

    [ZEPPELIN-6288] Replace Yoda conditions in InterpreterFactory with standard 
null checks
    
    ### What is this PR for?
    
    In `src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java`
    
    The codebase contains several instances of Yoda conditions (e.g., `if (null 
!= setting)`) which negatively impact code readability.
    
    Additionally, the use of these checks causes inconsistencies with the 
existing codebase style. So, this improvement aligns the code with the standard 
null-check style.
    
    
    ### What type of PR is it?
    Refactoring
    
    ### Todos
    * [x] - Refactor null-check style
    
    ### What is the Jira issue?
    * [ZEPPELIN-6288](https://issues.apache.org/jira/browse/ZEPPELIN-6288)
    
    ### How should this be tested?
    * As this modification involves no functional changes but only coding style 
improvements, passing existing tests ensures there are no issues.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the license files need to update? - No
    * Is there breaking changes for older versions? - No
    * Does this needs documentation? - No
    
    
    Closes #5037 from hyunw9/origin/ZEPPELIN-6288.
    
    Signed-off-by: Philipp Dallig <philipp.dal...@gmail.com>
---
 .../main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
 
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
index 03460febf6..95dbce1e81 100644
--- 
a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
+++ 
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
@@ -52,7 +52,7 @@ public class InterpreterFactory implements 
InterpreterFactoryInterface {
       String group = replNameSplits[0];
       String name = replNameSplits[1];
       InterpreterSetting setting = interpreterSettingManager.getByName(group);
-      if (null != setting) {
+      if (setting != null) {
         Interpreter interpreter = setting.getInterpreter(executionContext, 
name);
         if (null != interpreter) {
           return interpreter;
@@ -74,7 +74,7 @@ public class InterpreterFactory implements 
InterpreterFactoryInterface {
 
       // then assume interpreter name is omitted
       setting = interpreterSettingManager.getByName(replName);
-      if (null != setting) {
+      if (setting != null) {
         return setting.getDefaultInterpreter(executionContext);
       }
     }