This is an automated email from the ASF dual-hosted git repository.
jongyoul pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new eb2e03efca [ZEPPELIN-6255] added message in the
create-repository-modal for user not to be confused
eb2e03efca is described below
commit eb2e03efca031cd4f0695af6ba252d00b142dfad
Author: yunajoe <[email protected]>
AuthorDate: Fri Aug 15 14:14:18 2025 +0900
[ZEPPELIN-6255] added message in the create-repository-modal for user not
to be confused
…g a repository with an existing ID will update the existing repository
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/contributions.html
- Currently, users can update the configuration of a registered repository
used for dependency resolution by creating a new entry with the same ID under
Add New Repository, but with different settings.
However, this behavior is not intuitive, and users may not realize that
modifying an existing repository is possible in this way.
To improve clarity, we’ve added a simple explanation to the Interpreter
page UI, informing users that creating a repository with an existing ID will
update the existing configuration rather than creating a new one.
Alternatively, in the future, it may be worth considering implementing a
dedicated Edit Repository feature, along with an option to Remove Repository,
to make this workflow even clearer.
### What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
*Please leave your type of PR only*
- Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg.
[ZEPPELIN-533]
- [ZEPPELIN-6255]
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed
behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
<img width="789" height="680" alt="image"
src="https://github.com/user-attachments/assets/f1f3481e-1cdb-4757-bfec-25bab2944060";
/>
### Questions:
* Does the license files need to update?
* Is there breaking changes for older versions?
* Does this needs documentation?
Closes #5011 from yunajoe/feature/6255.
Signed-off-by: Jongyoul Lee <[email protected]>
---
zeppelin-web-angular/.gitignore | 2 +-
zeppelin-web-angular/package.json | 2 +-
zeppelin-web-angular/proxy.conf.js | 6 +-
.../create-repository-modal.component.html | 65 +++++-----------------
4 files changed, 18 insertions(+), 57 deletions(-)
diff --git a/zeppelin-web-angular/.gitignore b/zeppelin-web-angular/.gitignore
index 22b094f61f..f8d26a31a3 100644
--- a/zeppelin-web-angular/.gitignore
+++ b/zeppelin-web-angular/.gitignore
@@ -44,4 +44,4 @@ Thumbs.db
#
.env
-yarn.lock
\ No newline at end of file
+yarn.lock
diff --git a/zeppelin-web-angular/package.json
b/zeppelin-web-angular/package.json
index fe4e7cad6c..0a2f359075 100644
--- a/zeppelin-web-angular/package.json
+++ b/zeppelin-web-angular/package.json
@@ -99,4 +99,4 @@
"pre-commit": "lint-staged"
}
}
-}
\ No newline at end of file
+}
diff --git a/zeppelin-web-angular/proxy.conf.js
b/zeppelin-web-angular/proxy.conf.js
index c3d571ce3e..a59d554df8 100644
--- a/zeppelin-web-angular/proxy.conf.js
+++ b/zeppelin-web-angular/proxy.conf.js
@@ -25,13 +25,13 @@ const proxyConfig = [
context: '/ws',
target: 'ws://localhost:8080',
secure: false,
- ws:true,
+ ws: true,
changeOrigin: true
}
];
function httpUrlToWSUrl(url) {
- return url.replace(/(http)(s)?\:\/\//, "ws$2://");
+ return url.replace(/(http)(s)?\:\/\//, 'ws$2://');
}
function setupForCorporateProxy(proxyConfig) {
@@ -44,7 +44,7 @@ function setupForCorporateProxy(proxyConfig) {
}
proxyConfig.forEach(function(entry) {
if (entry.context === '/ws') {
- entry.target = httpUrlToWSUrl(proxyServer)
+ entry.target = httpUrlToWSUrl(proxyServer);
} else {
entry.target = proxyServer;
}
diff --git
a/zeppelin-web-angular/src/app/pages/workspace/interpreter/create-repository-modal/create-repository-modal.component.html
b/zeppelin-web-angular/src/app/pages/workspace/interpreter/create-repository-modal/create-repository-modal.component.html
index 57a0b6339d..fb0b72e69b 100644
---
a/zeppelin-web-angular/src/app/pages/workspace/interpreter/create-repository-modal/create-repository-modal.component.html
+++
b/zeppelin-web-angular/src/app/pages/workspace/interpreter/create-repository-modal/create-repository-modal.component.html
@@ -11,17 +11,15 @@
-->
<form nz-form [nzLayout]="'horizontal'" [formGroup]="validateForm"
(ngSubmit)="handleSubmit()">
+ <p style="color: #1890ff; font-size: 12px;">
+ Adding a repository with an existing ID will update the existing
repository.
+ </p>
<nz-form-item>
<nz-form-label [nzSpan]="6" nzRequired>
ID
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- autofocus
- formControlName="id"
- placeholder="Repository id"
- />
+ <input nz-input autofocus formControlName="id" placeholder="Repository
id" />
</nz-form-control>
</nz-form-item>
<nz-form-item>
@@ -30,15 +28,10 @@
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
<nz-input-group [nzAddOnBefore]="addOnBeforeTemplate">
- <input type="text"
- nz-input
- formControlName="url"
- placeholder="Repository url">
+ <input type="text" nz-input formControlName="url"
placeholder="Repository url" />
</nz-input-group>
<ng-template #addOnBeforeTemplate>
- <nz-select name="urlProtocol"
- [(ngModel)]="urlProtocol"
- [ngModelOptions]="{standalone: true}">
+ <nz-select name="urlProtocol" [(ngModel)]="urlProtocol"
[ngModelOptions]="{ standalone: true }">
<nz-option [nzLabel]="'http://'" [nzValue]="'http://'"></nz-option>
<nz-option [nzLabel]="'https://'" [nzValue]="'https://'"></nz-option>
<nz-option [nzLabel]="'file://'" [nzValue]="'file://'"></nz-option>
@@ -59,11 +52,7 @@
Username
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- formControlName="username"
- placeholder="username"
- />
+ <input nz-input formControlName="username" placeholder="username" />
</nz-form-control>
</nz-form-item>
<nz-form-item>
@@ -71,12 +60,7 @@
Password
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- type="password"
- formControlName="password"
- placeholder="password"
- />
+ <input nz-input type="password" formControlName="password"
placeholder="password" />
</nz-form-control>
</nz-form-item>
<nz-divider nzType="horizontal"></nz-divider>
@@ -96,11 +80,7 @@
Host
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- formControlName="proxyHost"
- placeholder="proxy host"
- />
+ <input nz-input formControlName="proxyHost" placeholder="proxy host" />
</nz-form-control>
</nz-form-item>
<nz-form-item>
@@ -108,11 +88,7 @@
Port
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- formControlName="proxyPort"
- placeholder="proxy port"
- />
+ <input nz-input formControlName="proxyPort" placeholder="proxy port" />
</nz-form-control>
</nz-form-item>
<nz-form-item>
@@ -120,11 +96,7 @@
Login
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- formControlName="proxyLogin"
- placeholder="proxy login"
- />
+ <input nz-input formControlName="proxyLogin" placeholder="proxy login" />
</nz-form-control>
</nz-form-item>
<nz-form-item>
@@ -132,24 +104,13 @@
Password
</nz-form-label>
<nz-form-control nz-col [nzSpan]="16">
- <input
- nz-input
- type="password"
- formControlName="proxyLogin"
- placeholder="proxy password"
- />
+ <input nz-input type="password" formControlName="proxyLogin"
placeholder="proxy password" />
</nz-form-control>
</nz-form-item>
</form>
<div class="modal-footer ant-modal-footer">
- <button
- nz-button
- nzType="primary"
- [disabled]="!validateForm.valid"
- (click)="handleSubmit()"
- [nzLoading]="submitting"
- >
+ <button nz-button nzType="primary" [disabled]="!validateForm.valid"
(click)="handleSubmit()" [nzLoading]="submitting">
Add
</button>
<button nz-button (click)="handleCancel()">
