This is an automated email from the ASF dual-hosted git repository.

pdallig pushed a commit to branch branch-0.12
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.12 by this push:
     new f1eee0ea88 [ZEPPELIN-6176] imagePullSecrets is skipped in interpreter 
other than spark
f1eee0ea88 is described below

commit f1eee0ea88290901c9ac261d70602737bfc0af3d
Author: Halim Kim <halim....@navercorp.com>
AuthorDate: Fri Apr 18 16:18:04 2025 +0900

    [ZEPPELIN-6176] imagePullSecrets is skipped in interpreter other than spark
    
    ### What is this PR for?
    interpreters that are not in spark group skip imagePullSecrets field so 
that container image pulling get failed
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-6176
    
    ### How should this be tested?
    manual test done (python interpreter with spark connect)
    
    ### Questions:
    * Does the license files need to update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Closes #4914 from HalimKim/ZEPPELIN-6176.
    
    Signed-off-by: Philipp Dallig <philipp.dal...@gmail.com>
    (cherry picked from commit 033c436903fe3d2ef19bc93ecc172569e0374f24)
    Signed-off-by: Philipp Dallig <philipp.dal...@gmail.com>
---
 k8s/interpreter/100-interpreter-spec.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/k8s/interpreter/100-interpreter-spec.yaml 
b/k8s/interpreter/100-interpreter-spec.yaml
index b21e4792cd..0f18379662 100644
--- a/k8s/interpreter/100-interpreter-spec.yaml
+++ b/k8s/interpreter/100-interpreter-spec.yaml
@@ -42,6 +42,12 @@ spec:
   {% endif %}
   restartPolicy: Never
   terminationGracePeriodSeconds: 30
+  {% if zeppelin.k8s.interpreter.imagePullSecrets is defined %}
+  imagePullSecrets:
+  {% for secret in zeppelin.k8s.interpreter.imagePullSecrets.split(',') %}
+  - name: {{secret}}
+  {% endfor %}
+  {% endif %}
   containers:
   - name: {{zeppelin.k8s.interpreter.container.name}}
     image: {{zeppelin.k8s.interpreter.container.image}}
@@ -101,12 +107,6 @@ spec:
     volumeMounts:
     - name: spark-home
       mountPath: /spark
-  {% if zeppelin.k8s.interpreter.imagePullSecrets is defined %}
-  imagePullSecrets:
-  {% for secret in zeppelin.k8s.interpreter.imagePullSecrets.split(',') %}
-  - name: {{secret}}
-  {% endfor %}
-  {% endif %}
   volumes:
   - name: spark-home
     emptyDir: {}

Reply via email to