This is an automated email from the ASF dual-hosted git repository. pdallig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push: new 97b12e6a6c [ZEPPELIN-6147] Make interpreter searching case-insensitive in new ui 97b12e6a6c is described below commit 97b12e6a6cf56c919ee0c0805fa7597fb9524ed3 Author: SeungYoung Oh <seung...@naver.com> AuthorDate: Mon Nov 11 15:27:23 2024 +0900 [ZEPPELIN-6147] Make interpreter searching case-insensitive in new ui ### What is this PR for? The interpreter search in the new UI doesn’t ignore case sensitivity, unlike the old UI. I updated it to be case-insensitive in the new UI as well for better UX. ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? [ZEPPELIN-6147](https://issues.apache.org/jira/browse/ZEPPELIN-6147/) ### How should this be tested? * Ensure interpreters can be searched case-insensitively ### Screenshots (if appropriate) **old ui** <img src="https://github.com/user-attachments/assets/3096ed71-6e76-4dcb-b3db-ecac9d1ca2e6" width="450" /> **new ui (before update)** <img src="https://github.com/user-attachments/assets/371bdc9f-a0d2-47bd-b3c0-1786470758a9" width="450" /> ### Questions: * Does the license files need to update? * Is there breaking changes for older versions? * Does this needs documentation? Closes #4897 from seung-00/ZEPPELIN-6147. Signed-off-by: Philipp Dallig <philipp.dal...@gmail.com> --- .../src/app/pages/workspace/interpreter/interpreter.component.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/zeppelin-web-angular/src/app/pages/workspace/interpreter/interpreter.component.ts b/zeppelin-web-angular/src/app/pages/workspace/interpreter/interpreter.component.ts index 0507cd8313..def7b09536 100644 --- a/zeppelin-web-angular/src/app/pages/workspace/interpreter/interpreter.component.ts +++ b/zeppelin-web-angular/src/app/pages/workspace/interpreter/interpreter.component.ts @@ -46,7 +46,10 @@ export class InterpreterComponent implements OnInit, OnDestroy { } filterInterpreters(value: string) { - this.filteredInterpreterSettings = this.interpreterSettings.filter(e => e.name.search(value) !== -1); + this.filteredInterpreterSettings = this.interpreterSettings.filter( + e => e.name.search(new RegExp(value, 'i')) !== -1 + ); + this.cdr.markForCheck(); }