This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new cd31c31d8d [ZEPPELIN-6096] Cursor appears cut off in Notebook editor
cd31c31d8d is described below

commit cd31c31d8d17c2d117bea1a03edee121bead8f64
Author: YONGJAE LEE(이용재) <[email protected]>
AuthorDate: Wed Oct 16 11:51:06 2024 +0900

    [ZEPPELIN-6096] Cursor appears cut off in Notebook editor
    
    ### What is this PR for?
    
    
https://github.com/user-attachments/assets/6204b6f5-409e-4cd1-8901-eb09114e9ded
    
    Steps to reproduce:
    1. Make a new Paragraph.
    2. Refresh the page.
    3. Click on the paragraph to make the cursor blink.
    
    [How to solve]
    
https://github.com/apache/zeppelin/blob/bdf5b067b6bdde2614b98a6a3f6a7b5d6637e57c/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts#L62
    
    Set default value of editor's height
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    
    ### What is the Jira issue?
    * [[ZEPPELIN-6096](https://issues.apache.org/jira/browse/ZEPPELIN-6096)]
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the license files need to update? N
    * Is there breaking changes for older versions? N
    * Does this needs documentation? N
    
    
    Closes #4873 from dididy/fix/ZEPPELIN-6096.
    
    Signed-off-by: Cheng Pan <[email protected]>
---
 .../workspace/notebook/paragraph/code-editor/code-editor.component.ts   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts
 
b/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts
index c1b01ccb47..a9e2de23f2 100644
--- 
a/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts
+++ 
b/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts
@@ -59,7 +59,7 @@ export class NotebookParagraphCodeEditorComponent implements 
OnChanges, OnDestro
   @Output() readonly editorFocus = new EventEmitter<void>();
   private editor: IStandaloneCodeEditor;
   private monacoDisposables: IDisposable[] = [];
-  height = 0;
+  height = 18;
   interpreterName: string;
 
   autoAdjustEditorHeight() {

Reply via email to