This is an automated email from the ASF dual-hosted git repository.

pdallig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 99848c9734 [ZEPPELIN-5891]Delete cloneNoteMeta method and replace it 
with createNoteAuth. (#4578)
99848c9734 is described below

commit 99848c9734f65fa5ae06f6344dd7178360d493f2
Author: YiningGong <nicolasgon...@gmail.com>
AuthorDate: Tue Apr 11 16:12:27 2023 +0800

    [ZEPPELIN-5891]Delete cloneNoteMeta method and replace it with 
createNoteAuth. (#4578)
    
    Co-authored-by: gyn <gyn>
---
 .../main/java/org/apache/zeppelin/notebook/AuthorizationService.java | 5 -----
 .../src/main/java/org/apache/zeppelin/notebook/Notebook.java         | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git 
a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java
 
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java
index d8fb3b798e..8c05ac09a5 100644
--- 
a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java
+++ 
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java
@@ -94,11 +94,6 @@ public class AuthorizationService implements 
ClusterEventListener {
     this.notesAuth.put(noteId, noteAuth);
   }
 
-  public void cloneNoteMeta(String noteId, String sourceNoteId, 
AuthenticationInfo subject) {
-    NoteAuth noteAuth = new NoteAuth(noteId, subject, conf);
-    this.notesAuth.put(noteId, noteAuth);
-  }
-
   /**
    * Persistent NoteAuth
    *
diff --git 
a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java 
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
index 52bad06890..3513ec0c82 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
@@ -414,7 +414,7 @@ public class Notebook {
             newNote.setRunning(false);
 
             saveNote(newNote, subject);
-            authorizationService.cloneNoteMeta(newNote.getId(), sourceNoteId, 
subject);
+            authorizationService.createNoteAuth(newNote.getId(), subject);
             return null;
           });
 

Reply via email to