This is an automated email from the ASF dual-hosted git repository.
zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new e29fc93 ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
e29fc93 is described below
commit e29fc9355f4ab3d1ebc849047f26f366a42c53d5
Author: Martin Tzvetanov Grigorov <mgrigo...@apache.org>
AuthorDate: Mon Sep 27 14:04:45 2021 +0300
ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
### What is this PR for?
Replaces the usage of PhantomJS for the JavaScript tests with headless
Firefox.
PhantomJS is not maintained since few years.
Using a real browser will make the tests more close to the real usage.
### What type of PR is it?
Improvement
### What is the Jira issue?
* Jira https://issues.apache.org/jira/browse/ZEPPELIN-5542
### How should this be tested?
* `mvn test -Pweb-e2e` should pass for `zeppenlin-web` module
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: Martin Tzvetanov Grigorov <mgrigo...@apache.org>
Closes #4237 from martin-g/zeppelin-5542-use-headless-firefox-for-e2e-tests
and squashes the following commits:
554c9f2ce9 [Martin Tzvetanov Grigorov] ZEPPELIN-5542 Use headless Firefox
instead of PhantomJS
---
zeppelin-web/karma.conf.js | 11 ++++++++++-
zeppelin-web/package.json | 3 +--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/zeppelin-web/karma.conf.js b/zeppelin-web/karma.conf.js
index e122648..018ccb5 100644
--- a/zeppelin-web/karma.conf.js
+++ b/zeppelin-web/karma.conf.js
@@ -115,7 +115,16 @@ module.exports = function(config) {
// - Safari (only Mac)
// - PhantomJS
// - IE (only Windows)
- browsers: [ 'PhantomJS' ],
+ browsers: [ 'FirefoxHeadless' ],
+
+ plugins: [
+ 'karma-coverage',
+ 'karma-jasmine',
+ 'karma-sourcemap-loader',
+ 'karma-webpack',
+ 'karma-spec-reporter',
+ 'karma-firefox-launcher',
+ ],
reporters: ['spec', 'coverage'],
diff --git a/zeppelin-web/package.json b/zeppelin-web/package.json
index de83a62..386bd9d 100644
--- a/zeppelin-web/package.json
+++ b/zeppelin-web/package.json
@@ -21,7 +21,6 @@
"test:watch": "karma start karma.conf.js --single-run=false",
"pree2e": "webdriver-manager update --gecko false --versions.chrome=2.35",
"e2e": "protractor protractor.conf.js",
- "pretest": "npm rebuild phantomjs-prebuilt",
"karma-test": "karma start karma.conf.js"
},
"dependencies": {
@@ -83,9 +82,9 @@
"karma": "~3.1.3",
"karma-coverage": "^1.1.2",
"karma-jasmine": "~2.0.1",
- "karma-phantomjs-launcher": "^1.0.4",
"karma-sourcemap-loader": "^0.3.7",
"karma-spec-reporter": "0.0.31",
+ "karma-firefox-launcher": "2.1.1",
"karma-webpack": "^3.0.5",
"load-grunt-tasks": "^0.4.0",
"mini-css-extract-plugin": "^0.4.4",
