[zeppelin] branch master updated: [ZEPPELIN-4593]. Failed to get completion in ShinyInterpreter

[zjffdu]

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new e7304e8  [ZEPPELIN-4593]. Failed to get completion in ShinyInterpreter
e7304e8 is described below

commit e7304e801e73bfe041b4f31af04595002b644633
Author: Jeff Zhang <zjf...@apache.org>
AuthorDate: Tue Feb 4 10:53:54 2020 +0800

    [ZEPPELIN-4593]. Failed to get completion in ShinyInterpreter
    
    ### What is this PR for?
    The root cause is that we didn't implement `completion` method, so it would 
always return null which cause the error. This PR fix it by always return empty 
List for `completion` method in `AbstractInterpreter`.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-4593
    
    ### How should this be tested?
    * Tested manully
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zjf...@apache.org>
    
    Closes #3628 from zjffdu/ZEPPELIN-4593 and squashes the following commits:
    
    c6bc66852 [Jeff Zhang] [ZEPPELIN-4593]. Failed to get completion in 
ShinyInterpreter
---
 .../org/apache/zeppelin/interpreter/AbstractInterpreter.java  | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git 
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/AbstractInterpreter.java
 
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/AbstractInterpreter.java
index 72df2c8..3b39b0d 100644
--- 
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/AbstractInterpreter.java
+++ 
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/AbstractInterpreter.java
@@ -17,6 +17,10 @@
 
 package org.apache.zeppelin.interpreter;
 
+import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion;
+
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Properties;
 
 public abstract class AbstractInterpreter extends Interpreter {
@@ -52,4 +56,11 @@ public abstract class AbstractInterpreter extends 
Interpreter {
   protected abstract InterpreterResult internalInterpret(
           String st,
           InterpreterContext context) throws InterpreterException;
+
+  @Override
+  public List<InterpreterCompletion> completion(String buf,
+                                                int cursor,
+                                                InterpreterContext 
interpreterContext) throws InterpreterException {
+    return new ArrayList<>();
+  }
 }