This is an automated email from the ASF dual-hosted git repository.
zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new ce0ee4e [ZEPPELIN-4575] Switched to the use of noteName variable
instead of notePath variable for note title
ce0ee4e is described below
commit ce0ee4ed0567948e675a6b5bc5ae817f10216b4c
Author: Muhammad-ms <59560973+muhammad...@users.noreply.github.com>
AuthorDate: Mon Jan 20 16:41:12 2020 +0000
[ZEPPELIN-4575] Switched to the use of noteName variable instead of
notePath variable for note title
### What is this PR for?
The variable noteName does not contain leading "/", unlike notePath.
Therefore, using former prevents the leading "/" from appearing in the note
name displayed on Zeppelin page.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4575
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE SOFTWARE
FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT VERSION
R190612.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND
ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE
COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS [...]
Author: Muhammad-ms <59560973+muhammad...@users.noreply.github.com>
Author: Muhammad Taufiq <muhammad.tau...@morganstanley.com>
Closes #3616 from Muhammad-ms/zeppelin9_noteTitle and squashes the
following commits:
a3b79bee7 [Muhammad Taufiq] [ZEPPELIN-4575] Switched to the use of noteName
variable instead of notePath variable as it does not contain leading /
4f532aad5 [Muhammad-ms] Merge pull request #1 from apache/master
---
zeppelin-web/src/app/notebook/notebook-actionBar.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/zeppelin-web/src/app/notebook/notebook-actionBar.html
b/zeppelin-web/src/app/notebook/notebook-actionBar.html
index b37b913..2dab5cf 100644
--- a/zeppelin-web/src/app/notebook/notebook-actionBar.html
+++ b/zeppelin-web/src/app/notebook/notebook-actionBar.html
@@ -24,7 +24,7 @@ limitations under the License.
tooltip-placement="bottom"
uib-tooltip={{noteName(note)}}
ng-click="input.showEditor = !revisionView; input.value = note.name"
- ng-show="!input.showEditor"><span>{{notePath(note)}}</span></p>
+ ng-show="!input.showEditor"><span>{{noteName(note)}}</span></p>
</div>
<div style="float: left; padding-bottom: 10px">
<span class="labelBtn btn-group">
