Repository: zeppelin Updated Branches: refs/heads/master b31f2998e -> 6e97a527e
[ZEPPELIN-3847] Duplicate results in notebooks due to WS interruption ### What is this PR for? Duplicate results in notebooks after ws reconnect. The problem occurs via duplicated 'setConnectedStatus' event handler in notebook.controller.js. The same function exists at https://github.com/Leemoonsoo/zeppelin/blob/dbbf0436490941d117fd4c06b9da5b6cb47697ff/zeppelin-web/src/app/notebook/notebook.controller.js#L99-L104. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3847 ### How should this be tested? Disconnect and reconnect websocket connection to browser, and check if result is duplicated. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <leemoon...@gmail.com> Closes #3230 from Leemoonsoo/ZEPPELIN-3847 and squashes the following commits: dbbf04364 [Lee moon soo] remove duplicated setConnectedStatus event handler Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/6e97a527 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/6e97a527 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/6e97a527 Branch: refs/heads/master Commit: 6e97a527e1a2c84846a18340ad11f05ff6432cdc Parents: b31f299 Author: Lee moon soo <leemoon...@gmail.com> Authored: Sat Nov 17 10:06:30 2018 +0900 Committer: Lee moon soo <m...@apache.org> Committed: Mon Nov 19 07:26:32 2018 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/notebook.controller.js | 7 ------- 1 file changed, 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/6e97a527/zeppelin-web/src/app/notebook/notebook.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 047b022..2f1437d 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -1361,13 +1361,6 @@ function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope, $scope.$broadcast('focusParagraph', paragraph.id, row + 1, col); }; - $scope.$on('setConnectedStatus', function(event, param) { - if (connectedOnce && param) { - initNotebook(); - } - connectedOnce = true; - }); - $scope.$on('moveParagraphUp', function(event, paragraph) { let newIndex = -1; for (let i = 0; i < $scope.note.paragraphs.length; i++) {
