Repository: zeppelin Updated Branches: refs/heads/branch-0.7 d4cacadaf -> 22fecd3e5 (forced update)
fix bugs for timer saver * add saveNote action when cron schedule setting in file notebook.controller.js * case: open one noteï¼edit some text in a paragraph, then do a cron schedule setting, the content which just edited disappeared * change invoke method for the timer saver in file paragraph.controller.js * case: open one browserï¼edit some text in a paragraph, then open the note in other browserï¼you will find that the text you just edited did not be synced [Bug Fix] * [ ] - Task [ZEPPELIN-2323](https://issues.apache.org/jira/browse/ZEPPELIN-2323) Outline the steps to test the PR here. * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: LeiWang <wanglei6...@163.com> Author: lei wang <lei1...@outlook.com> Closes #2196 from wary/master and squashes the following commits: b2ee2f9 [LeiWang] Update notebook.controller.js 2ab58c3 [LeiWang] Update notebook.controller.js 9908227 [LeiWang] Update paragraph.controller.js 3612f56 [lei wang] fix bugs for timer saver (cherry picked from commit 902892a97723b0c4deb4ef832588067a0faa9d74) Signed-off-by: Lee moon soo <m...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/22fecd3e Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/22fecd3e Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/22fecd3e Branch: refs/heads/branch-0.7 Commit: 22fecd3e5fe3df05df27443b22bd222b2395b15b Parents: 6955c8d Author: LeiWang <wanglei6...@163.com> Authored: Sun Apr 9 19:01:46 2017 +0800 Committer: Jongyoul Lee <jongy...@apache.org> Committed: Mon Apr 17 22:23:48 2017 +0900 ---------------------------------------------------------------------- .../src/app/notebook/paragraph/paragraph.controller.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/22fecd3e/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index 5e1d5c5..47d34c6 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -125,15 +125,15 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat var initializeDefault = function(config) { var forms = $scope.paragraph.settings.forms; - + if (!config.colWidth) { config.colWidth = 12; } - + if (config.enabled === undefined) { config.enabled = true; } - + for (var idx in forms) { if (forms[idx]) { if (forms[idx].options) { @@ -472,7 +472,7 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat var session = editor.getSession(); var dirtyText = session.getValue(); $scope.dirtyText = dirtyText; - $scope.$broadcast('startSaveTimer'); + $scope.startSaveTimer(); setParagraphMode(session, dirtyText, editor.getCursorPosition()); };
