Repository: zeppelin Updated Branches: refs/heads/master c23aa8871 -> 8a7117248
[MINOR] remove typo in line and area chart ### What is this PR for? The line and area chart have the typo `xLables`, not `xLabels`. However, this line is not necessary, because `xLabels` is defined by `render` function. That's why these chart was working well. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * None ### How should this be tested? - Run line and area chart and check whether it works well or not. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: soralee <sora0...@zepl.com> Closes #2214 from soralee/ZEPPLIN_remove_initial_code_in_Chart and squashes the following commits: c4ec2ee [soralee] remove initial code in chart Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8a711724 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8a711724 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8a711724 Branch: refs/heads/master Commit: 8a71172481299d1c28d8acfed776f6f8369c1ea2 Parents: c23aa88 Author: soralee <sora0...@zepl.com> Authored: Mon Apr 3 13:09:10 2017 +0900 Committer: Lee moon soo <m...@apache.org> Committed: Wed Apr 5 05:05:15 2017 +0900 ---------------------------------------------------------------------- .../src/app/visualization/builtins/visualization-areachart.js | 1 - .../src/app/visualization/builtins/visualization-linechart.js | 1 - 2 files changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8a711724/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js b/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js index 25ed16f..4e0d318 100644 --- a/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js +++ b/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js @@ -23,7 +23,6 @@ export default class AreachartVisualization extends Nvd3ChartVisualization { super(targetEl, config); this.pivot = new PivotTransformation(config); - this.xLables = []; }; type() { http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8a711724/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js b/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js index 02a2114..577001f 100644 --- a/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js +++ b/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js @@ -23,7 +23,6 @@ export default class LinechartVisualization extends Nvd3ChartVisualization { super(targetEl, config); this.pivot = new PivotTransformation(config); - this.xLables = []; }; type() {
