Repository: zeppelin Updated Branches: refs/heads/master 062c2a47c -> c91ec2be6
[ZEPPELIN-2302] Add info level logs when installing node modules and bundling helium pkgs ### What is this PR for? Add info level logs when installing node modules and bundling helium packages. - Because user cannot get noticed during 30secs ~ few minutes if you have multiple enabled helium packages - User might think that Zeppelin hangs or there is another problem If there is no log message. ### What type of PR is it? [Improvement] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2302](https://issues.apache.org/jira/browse/ZEPPELIN-2302) ### How should this be tested? 1. Enable some helium packages. 2. Then you will see log messages like ``` INFO [2017-03-23 14:57:32,709] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:227) - Installing required node modules INFO [2017-03-23 14:57:36,561] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:233) - Installed required node modules INFO [2017-03-23 14:57:36,562] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:244) - Bundling helium packages INFO [2017-03-23 14:57:38,092] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:246) - Bundled helium packages ``` ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1am...@gmail.com> Closes #2178 from 1ambda/ZEPPELIN-2302/add-logging-for-helium and squashes the following commits: 69f86d3 [1ambda] chore: Add info level for helium bundling Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c91ec2be Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c91ec2be Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c91ec2be Branch: refs/heads/master Commit: c91ec2be69094b2ce413e69188b60396c6e3884c Parents: 062c2a4 Author: 1ambda <1am...@gmail.com> Authored: Thu Mar 23 15:06:07 2017 +0900 Committer: ahyoungryu <ahyoung...@apache.org> Committed: Fri Mar 31 17:50:31 2017 +0900 ---------------------------------------------------------------------- .../java/org/apache/zeppelin/helium/HeliumBundleFactory.java | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c91ec2be/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java ---------------------------------------------------------------------- diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java index c776506..2dbefe0 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java @@ -228,7 +228,9 @@ public class HeliumBundleFactory { String.format("install --fetch-retries=%d --fetch-retry-factor=%d " + "--fetch-retry-mintimeout=%d", FETCH_RETRY_COUNT, FETCH_RETRY_FACTOR_COUNT, FETCH_RETRY_MIN_TIMEOUT); + logger.info("Installing required node modules"); npmCommand(commandForNpmInstall); + logger.info("Installed required node modules"); } catch (TaskRunnerException e) { // ignore `(empty)` warning String cause = new String(out.toByteArray()); @@ -239,7 +241,9 @@ public class HeliumBundleFactory { try { out.reset(); + logger.info("Bundling helium packages"); npmCommand("run bundle"); + logger.info("Bundled helium packages"); } catch (TaskRunnerException e) { throw new IOException(new String(out.toByteArray())); }
